Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757451AbcKXUSL (ORCPT ); Thu, 24 Nov 2016 15:18:11 -0500 Received: from relay1.mentorg.com ([192.94.38.131]:63529 "EHLO relay1.mentorg.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757276AbcKXUSJ (ORCPT ); Thu, 24 Nov 2016 15:18:09 -0500 Subject: Re: [PATCH] pinctrl: imx: fix imx_pinctrl_desc initialization To: Gary Bisson , References: <20161124181151.29419-1-gary.bisson@boundarydevices.com> CC: , , , From: Vladimir Zapolskiy Message-ID: Date: Thu, 24 Nov 2016 22:17:55 +0200 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:45.0) Gecko/20100101 Icedove/45.2.0 MIME-Version: 1.0 In-Reply-To: <20161124181151.29419-1-gary.bisson@boundarydevices.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [137.202.0.87] X-ClientProxiedBy: svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To SVR-IES-MBX-04.mgc.mentorg.com (139.181.222.4) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1453 Lines: 42 Hi Gary, On 11/24/2016 08:11 PM, Gary Bisson wrote: > Was introduced by: > 6e408ed pinctrl: imx: fix initialization of imx_pinctrl_desc > > Signed-off-by: Gary Bisson > --- > drivers/pinctrl/freescale/pinctrl-imx.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/pinctrl/freescale/pinctrl-imx.c b/drivers/pinctrl/freescale/pinctrl-imx.c > index 79c4e14..5ef7e87 100644 > --- a/drivers/pinctrl/freescale/pinctrl-imx.c > +++ b/drivers/pinctrl/freescale/pinctrl-imx.c > @@ -778,10 +778,10 @@ int imx_pinctrl_probe(struct platform_device *pdev, > imx_pinctrl_desc->name = dev_name(&pdev->dev); > imx_pinctrl_desc->pins = info->pins; > imx_pinctrl_desc->npins = info->npins; > - imx_pinctrl_desc->pctlops = &imx_pctrl_ops, > - imx_pinctrl_desc->pmxops = &imx_pmx_ops, > - imx_pinctrl_desc->confops = &imx_pinconf_ops, > - imx_pinctrl_desc->owner = THIS_MODULE, > + imx_pinctrl_desc->pctlops = &imx_pctrl_ops; > + imx_pinctrl_desc->pmxops = &imx_pmx_ops; > + imx_pinctrl_desc->confops = &imx_pinconf_ops; > + imx_pinctrl_desc->owner = THIS_MODULE; > > ret = imx_pinctrl_probe_dt(pdev, info); > if (ret) { > excellent catch, my compiler does not report the issue. Subject and commit message are not quite informative, but the change is trivial, so please feel free to add my Reviewed-by: Vladimir Zapolskiy -- With best wishes, Vladimir