Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941210AbcKXUfM (ORCPT ); Thu, 24 Nov 2016 15:35:12 -0500 Received: from mail-yw0-f193.google.com ([209.85.161.193]:33542 "EHLO mail-yw0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756748AbcKXUfK (ORCPT ); Thu, 24 Nov 2016 15:35:10 -0500 MIME-Version: 1.0 In-Reply-To: <58700ceb-5542-304d-2c7f-6c038b080798@mailbox.org> References: <1480015260-22515-1-git-send-email-sergio.paracuellos@gmail.com> <1480015260-22515-3-git-send-email-sergio.paracuellos@gmail.com> <58700ceb-5542-304d-2c7f-6c038b080798@mailbox.org> From: Sergio Paracuellos Date: Thu, 24 Nov 2016 21:35:09 +0100 Message-ID: Subject: Re: [PATCH v2 2/2] staging: slicoss: remove UPDATE_STATS_GB macro and inline code To: =?UTF-8?Q?Markus_B=C3=B6hme?= Cc: Greg KH , devel@driverdev.osuosl.org, linux-kernel , Lior Dotan Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id uAOKZG5b004037 Content-Length: 2177 Lines: 54 On Thu, Nov 24, 2016 at 8:41 PM, Markus Böhme wrote: > On 11/24/2016 08:21 PM, Sergio Paracuellos wrote: >> This patch removes UPDATE_STATS_GB macro in slic.h header file >> and just inline code. This improve readability. >> >> Signed-off-by: Sergio Paracuellos >> --- >> drivers/staging/slicoss/slic.h | 5 ---- >> drivers/staging/slicoss/slicoss.c | 52 +++++++++++++++++++-------------------- >> 2 files changed, 25 insertions(+), 32 deletions(-) >> >> diff --git a/drivers/staging/slicoss/slic.h b/drivers/staging/slicoss/slic.h >> index 2c05868..2893bdf 100644 >> --- a/drivers/staging/slicoss/slic.h >> +++ b/drivers/staging/slicoss/slic.h >> @@ -548,11 +548,6 @@ static inline void slic_flush_write(struct adapter *adapter) >> ioread32(adapter->regs + SLIC_REG_HOSTID); >> } >> >> -#define UPDATE_STATS_GB(largestat, newstat, oldstat) \ >> -{ \ >> - (largestat) += ((newstat) - (oldstat)); \ >> -} >> - >> #if BITS_PER_LONG == 64 >> #define SLIC_GET_ADDR_LOW(_addr) (u32)((u64)(_addr) & \ >> 0x00000000FFFFFFFF) >> diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c >> index b6ec0a1..ffc7c45 100644 >> --- a/drivers/staging/slicoss/slicoss.c >> +++ b/drivers/staging/slicoss/slicoss.c >> @@ -1014,45 +1014,43 @@ static void slic_upr_request_complete(struct adapter *adapter, u32 isr) >> break; >> } >> >> - UPDATE_STATS_GB(stst->tcp.xmit_tcp_segs, stats->xmit_tcp_segs, >> - old->xmit_tcp_segs); >> + stst->tcp.xmit_tcp_segs = >> + stats->xmit_tcp_segs - old->xmit_tcp_segs; > > Missed this the first time, but the difference should be added to the > value in stst: > > stst->tcp.xmit_tcp_segs += > stats->xmit_tcp_segs - old->xmit_tcp_segs; > > The same applies to the changes below. True. I have just sent v3 with these fixed. Thanks for let me know. Cheers, Sergio Paracuellos