Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966591AbcKXVHn (ORCPT ); Thu, 24 Nov 2016 16:07:43 -0500 Received: from mga06.intel.com ([134.134.136.31]:47302 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965927AbcKXVHl (ORCPT ); Thu, 24 Nov 2016 16:07:41 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,543,1473145200"; d="scan'208";a="790439288" Date: Thu, 24 Nov 2016 23:06:37 +0200 From: Jarkko Sakkinen To: Nayna Jain Cc: tpmdd-devel@lists.sourceforge.net, peterhuewe@gmx.de, tpmdd@selhorst.net, jgunthorpe@obsidianresearch.com, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 2/3] tpm: enhance read_log_of() to support Physical TPM event log Message-ID: <20161124210637.6dspokalv7tcql26@intel.com> References: <1479922057-8752-1-git-send-email-nayna@linux.vnet.ibm.com> <1479922057-8752-3-git-send-email-nayna@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1479922057-8752-3-git-send-email-nayna@linux.vnet.ibm.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 468 Lines: 13 On Wed, Nov 23, 2016 at 12:27:36PM -0500, Nayna Jain wrote: > - memcpy(log->bios_event_log, __va(*basep), *sizep); > + if (of_property_match_string(np, "compatible", "IBM,vtpm") < 0) > + memcpy(chip->log.bios_event_log, __va(be64_to_cpup(basep)), > + log_size); > + else > + memcpy(chip->log.bios_event_log, __va(*basep), log_size); This does not look good. You should be able rearrange your code in a way that you only have only one memcpy call. /Jarkko