Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752044AbcKXX4c (ORCPT ); Thu, 24 Nov 2016 18:56:32 -0500 Received: from mail-pg0-f65.google.com ([74.125.83.65]:34400 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751448AbcKXX4Y (ORCPT ); Thu, 24 Nov 2016 18:56:24 -0500 Subject: Re: [PATCH 1/5] mm: migrate: Add mode parameter to support additional page copy routines. To: Zi Yan , linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20161122162530.2370-1-zi.yan@sent.com> <20161122162530.2370-2-zi.yan@sent.com> Cc: akpm@linux-foundation.org, minchan@kernel.org, vbabka@suse.cz, mgorman@techsingularity.net, kirill.shutemov@linux.intel.com, n-horiguchi@ah.jp.nec.com, khandual@linux.vnet.ibm.com, Zi Yan , Zi Yan From: Balbir Singh Message-ID: Date: Fri, 25 Nov 2016 10:56:16 +1100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <20161122162530.2370-2-zi.yan@sent.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1927 Lines: 67 On 23/11/16 03:25, Zi Yan wrote: > From: Zi Yan > > From: Zi Yan > > migrate_page_copy() and copy_huge_page() are affected. > > Signed-off-by: Zi Yan > Signed-off-by: Zi Yan > --- > fs/aio.c | 2 +- > fs/hugetlbfs/inode.c | 2 +- > fs/ubifs/file.c | 2 +- > include/linux/migrate.h | 6 ++++-- > mm/migrate.c | 14 ++++++++------ > 5 files changed, 15 insertions(+), 11 deletions(-) > > diff --git a/fs/aio.c b/fs/aio.c > index 428484f..a67c764 100644 > --- a/fs/aio.c > +++ b/fs/aio.c > @@ -418,7 +418,7 @@ static int aio_migratepage(struct address_space *mapping, struct page *new, > * events from being lost. > */ > spin_lock_irqsave(&ctx->completion_lock, flags); > - migrate_page_copy(new, old); > + migrate_page_copy(new, old, 0); Can we have a useful enum instead of 0, its harder to read and understand 0 > BUG_ON(ctx->ring_pages[idx] != old); > ctx->ring_pages[idx] = new; > spin_unlock_irqrestore(&ctx->completion_lock, flags); > diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c > index 4fb7b10..a17bfef 100644 > --- a/fs/hugetlbfs/inode.c > +++ b/fs/hugetlbfs/inode.c > @@ -850,7 +850,7 @@ static int hugetlbfs_migrate_page(struct address_space *mapping, > rc = migrate_huge_page_move_mapping(mapping, newpage, page); > if (rc != MIGRATEPAGE_SUCCESS) > return rc; > - migrate_page_copy(newpage, page); > + migrate_page_copy(newpage, page, 0); Ditto > > return MIGRATEPAGE_SUCCESS; > } > diff --git a/fs/ubifs/file.c b/fs/ubifs/file.c > index b4fbeef..bf54e32 100644 > --- a/fs/ubifs/file.c > +++ b/fs/ubifs/file.c > @@ -1468,7 +1468,7 @@ static int ubifs_migrate_page(struct address_space *mapping, > SetPagePrivate(newpage); > } > > - migrate_page_copy(newpage, page); > + migrate_page_copy(newpage, page, 0); Here as well Balbir Singh.