Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751076AbcKYAVU (ORCPT ); Thu, 24 Nov 2016 19:21:20 -0500 Received: from one.firstfloor.org ([193.170.194.197]:37912 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750698AbcKYAVT (ORCPT ); Thu, 24 Nov 2016 19:21:19 -0500 Date: Thu, 24 Nov 2016 16:21:17 -0800 From: Andi Kleen To: Jiri Olsa Cc: "Liang, Kan" , "peterz@infradead.org" , "mingo@redhat.com" , "acme@kernel.org" , "linux-kernel@vger.kernel.org" , "alexander.shishkin@linux.intel.com" , "tglx@linutronix.de" , "namhyung@kernel.org" , "jolsa@kernel.org" , "Hunter, Adrian" , "wangnan0@huawei.com" , "mark.rutland@arm.com" , "andi@firstfloor.org" Subject: Re: [PATCH 06/14] perf tools: show NMI overhead Message-ID: <20161125002116.GF26852@two.firstfloor.org> References: <1479894292-16277-1-git-send-email-kan.liang@intel.com> <1479894292-16277-7-git-send-email-kan.liang@intel.com> <20161123225151.GC15978@krava> <37D7C6CF3E00A74B8858931C1DB2F07750CA2BBA@SHSMSX103.ccr.corp.intel.com> <20161124152721.GA5250@krava> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161124152721.GA5250@krava> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 704 Lines: 20 > how about we display the overhead information same way the main perf output: > > CPU NMI NMI time MTX MTX time SB SB time > ... ..... ........ ..... ........ ...... ........ > 6 27 111379 0 0 57 90045 > > > would be just matter of adding new sort objects The problem with making overhead a standard sort key is that you have to chose between an output format that makes sense for overhead and one that makes sense for normal samples. But overhead is more "auxillary" information, so it should be possible to access it together with normal sampling information in a single output file. So I think it's better handled separately. -Andi