Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751061AbcKYBRM (ORCPT ); Thu, 24 Nov 2016 20:17:12 -0500 Received: from mail-pf0-f193.google.com ([209.85.192.193]:35463 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750708AbcKYBRE (ORCPT ); Thu, 24 Nov 2016 20:17:04 -0500 Date: Fri, 25 Nov 2016 09:16:41 +0800 From: Peng Fan To: Gary Bisson Cc: hawnguo@kernel.org, linus.walleij@linaro.org, vladimir_zapolskiy@mentor.com, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] pinctrl: imx: fix imx_pinctrl_desc initialization Message-ID: <20161125011639.GA29245@linux-u7w5.ap.freescale.net> References: <20161124181151.29419-1-gary.bisson@boundarydevices.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161124181151.29419-1-gary.bisson@boundarydevices.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1264 Lines: 40 Hi Gary, On Thu, Nov 24, 2016 at 07:11:51PM +0100, Gary Bisson wrote: >Was introduced by: >6e408ed pinctrl: imx: fix initialization of imx_pinctrl_desc > >Signed-off-by: Gary Bisson >--- > drivers/pinctrl/freescale/pinctrl-imx.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > >diff --git a/drivers/pinctrl/freescale/pinctrl-imx.c b/drivers/pinctrl/freescale/pinctrl-imx.c >index 79c4e14..5ef7e87 100644 >--- a/drivers/pinctrl/freescale/pinctrl-imx.c >+++ b/drivers/pinctrl/freescale/pinctrl-imx.c >@@ -778,10 +778,10 @@ int imx_pinctrl_probe(struct platform_device *pdev, > imx_pinctrl_desc->name = dev_name(&pdev->dev); > imx_pinctrl_desc->pins = info->pins; > imx_pinctrl_desc->npins = info->npins; >- imx_pinctrl_desc->pctlops = &imx_pctrl_ops, >- imx_pinctrl_desc->pmxops = &imx_pmx_ops, >- imx_pinctrl_desc->confops = &imx_pinconf_ops, >- imx_pinctrl_desc->owner = THIS_MODULE, >+ imx_pinctrl_desc->pctlops = &imx_pctrl_ops; >+ imx_pinctrl_desc->pmxops = &imx_pmx_ops; >+ imx_pinctrl_desc->confops = &imx_pinconf_ops; >+ imx_pinctrl_desc->owner = THIS_MODULE; Thanks for the fix. Reviewed-by: Peng Fan > > ret = imx_pinctrl_probe_dt(pdev, info); > if (ret) { >-- >2.9.3 > --