Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752106AbcKYCvZ (ORCPT ); Thu, 24 Nov 2016 21:51:25 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:56669 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751515AbcKYCvR (ORCPT ); Thu, 24 Nov 2016 21:51:17 -0500 Subject: Re: [tpmdd-devel] [PATCH v5 3/3] tpm: add securityfs support for TPM 2.0 firmware event log To: Jarkko Sakkinen , Nayna Jain References: <1479922057-8752-1-git-send-email-nayna@linux.vnet.ibm.com> <1479922057-8752-4-git-send-email-nayna@linux.vnet.ibm.com> <20161124211057.xynmfteky5r7uc27@intel.com> Cc: linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, tpmdd-devel@lists.sourceforge.net From: Stefan Berger Date: Thu, 24 Nov 2016 21:51:03 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <20161124211057.xynmfteky5r7uc27@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16112502-0040-0000-0000-000001F67EB8 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00006137; HX=3.00000240; KW=3.00000007; PH=3.00000004; SC=3.00000192; SDB=6.00785100; UDB=6.00379338; IPR=6.00562681; BA=6.00004908; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00013432; XFM=3.00000011; UTC=2016-11-25 02:51:12 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16112502-0041-0000-0000-000005E8818A Message-Id: <11f97863-aa40-a9aa-836f-4b446faf1ed3@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-11-24_11:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1609300000 definitions=main-1611250047 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1445 Lines: 36 On 11/24/2016 04:10 PM, Jarkko Sakkinen wrote: > On Wed, Nov 23, 2016 at 12:27:37PM -0500, Nayna Jain wrote: >> Unlike the device driver support for TPM 1.2, the TPM 2.0 does >> not support the securityfs pseudo files for displaying the >> firmware event log. >> >> This patch enables support for providing the TPM 2.0 event log in >> binary form. TPM 2.0 event log supports a crypto agile format that >> records multiple digests, which is different from TPM 1.2. This >> patch enables the tpm_bios_log_setup for TPM 2.0 and adds the >> event log parser which understand the TPM 2.0 crypto agile format. >> >> Signed-off-by: Nayna Jain > I don't want to say much about this before I've tested it. I wonder > what cheap hardware I could use to test this. Any advice is on this > from anyone is much appreciated. Virtual hardware would be cheap :-) I tested this series with QEMU + vTPM + SeaBIOS with TPM 1.2 + TPM 2 support (basing the log on ACPI). I had to fix an endianess issue on the SeaBIOS side, which made it work. So for this version of the patches I can give it my tested-by: Tested-by: Stefan Berger > > /Jarkko > > ------------------------------------------------------------------------------ > _______________________________________________ > tpmdd-devel mailing list > tpmdd-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/tpmdd-devel >