Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752483AbcKYEmN (ORCPT ); Thu, 24 Nov 2016 23:42:13 -0500 Received: from mailout3.samsung.com ([203.254.224.33]:46880 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751734AbcKYEmF (ORCPT ); Thu, 24 Nov 2016 23:42:05 -0500 X-AuditID: cbfee61a-f79916d0000062de-65-5837c110797d From: Shailendra Verma To: Mauro Carvalho Chehab , Kukjin Kim , Krzysztof Kozlowski , Javier Martinez Canillas , Kyungmin Park , Sylwester Nawrocki , linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Shailendra Verma , Shailendra Verma Cc: vidushi.koul@samsung.com Subject: [PATCH] Media: Platform: Exynos4-is: - Fix for error handling Date: Fri, 25 Nov 2016 10:09:31 +0530 Message-id: <1480048771-19745-1-git-send-email-shailendra.v@samsung.com> X-Mailer: git-send-email 1.7.9.5 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrGLMWRmVeSWpSXmKPExsVy+t9jQV2Bg+YRBi2nTSzevF3DZNH/+DWz xfnzG9gtzja9YbfY9Pgaq8XlXXPYLHo2bGW1mHF+H5PFsk1/mCwOv2lntbg1byabxaJvr5gt /l68xObA67Fz1l12j02rOtk8Ni+p99jSD+T1bVnF6PF5k1wAW5SbTUZqYkpqkUJqXnJ+SmZe uq1SaIibroWSQl5ibqqtUoSub0iQkkJZYk4pkGdkgAYcnAPcg5X07RLcMs6emspasIit4v79 5ywNjOtYuxg5OSQETCRuvvvADGGLSVy4t56ti5GLQ0hgFqNEf+9tVgjnJ6PEmsOHmUCq2AQM JV73/WUCSYgIfGSW+HB5LztIgllARmLfxDawImEBN4m3i08DjeLgYBFQlbg81RQkzCvgIfFg egcTSFhCQEFiziSbCYzcCxgZVjFKpBYkFxQnpeca5qWW6xUn5haX5qXrJefnbmIEh/kzqR2M B3e5H2IU4GBU4uGdkG4eIcSaWFZcmXuIUYKDWUmEN2A/UIg3JbGyKrUoP76oNCe1+BCjKdD6 icxSosn5wBjMK4k3NDE3MTc2sDC3tDQxUhLnbZz9LFxIID2xJDU7NbUgtQimj4mDU6qB8XCY SvsJ27juxVPPfQxy2Ol3MrSzd3qM4nOF6AiWRTerlj/5vln8s9fP86qRzsuEBRcm9ijHSPet vsLW2XiyPPZhQdy6m1bvBSRD+1dcP+cXfJ13zqqAG4vi/rGWl6iZJH/lUn+71fWH3pOYA/+S i06vrb+hu66q9I+dwb93Z8unhTgyRz7bqMRSnJFoqMVcVJwIAOy39dqJAgAA X-MTR: 20000000000000000@CPGS Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 776 Lines: 24 The File handle is not yet added in the vfd list.So no need to call v4l2_fh_del(&ctx->fh) if it fails to create control. Signed-off-by: Shailendra Verma --- drivers/media/platform/exynos4-is/fimc-m2m.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/exynos4-is/fimc-m2m.c b/drivers/media/platform/exynos4-is/fimc-m2m.c index 6028e4f..d8724fe 100644 --- a/drivers/media/platform/exynos4-is/fimc-m2m.c +++ b/drivers/media/platform/exynos4-is/fimc-m2m.c @@ -663,8 +663,8 @@ static int fimc_m2m_open(struct file *file) v4l2_m2m_ctx_release(ctx->fh.m2m_ctx); error_c: fimc_ctrls_delete(ctx); -error_fh: v4l2_fh_del(&ctx->fh); +error_fh: v4l2_fh_exit(&ctx->fh); kfree(ctx); unlock: -- 1.7.9.5