Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752630AbcKYErC (ORCPT ); Thu, 24 Nov 2016 23:47:02 -0500 Received: from mailout1.samsung.com ([203.254.224.24]:60299 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750968AbcKYEqx (ORCPT ); Thu, 24 Nov 2016 23:46:53 -0500 X-AuditID: cbfee61b-f796f6d000004092-bc-5837c23b5c24 From: Shailendra Verma To: Mauro Carvalho Chehab , Laurent Pinchart , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Shailendra Verma , Shailendra Verma Cc: vidushi.koul@samsung.com Subject: [PATCH] Media: Platform: Omap3isp: Do not forget to call Date: Fri, 25 Nov 2016 10:14:32 +0530 Message-id: <1480049072-20019-1-git-send-email-shailendra.v@samsung.com> X-Mailer: git-send-email 1.7.9.5 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrCLMWRmVeSWpSXmKPExsVy+t9jAV3rQ+YRBn9mK1p0TlzCbnF51xw2 i54NW1ktlm36w2Rxa95MNotF314xW/y9eInNgd1j56y77B6zO2ayemxa1cnm0bdlFaPH501y AaxRbjYZqYkpqUUKqXnJ+SmZeem2SqEhbroWSgp5ibmptkoRur4hQUoKZYk5pUCekQEacHAO cA9W0rdLcMs40PyNvWA3a0XD0a1MDYznWboYOTkkBEwkGv++Z4awxSQu3FvP1sXIxSEksJRR 4uveL0wQzk9GiVu/NoB1sAkYSrzu+wuWEBFoZ5LoPXGCESTBLCAjsW9iG1CCg0NYwFFi9XYO kDCLgKrEhPuP2UBsXgEPiZ/XVzCDlEgIKEjMmWQzgZF7ASPDKkaJ1ILkguKk9FyjvNRyveLE 3OLSvHS95PzcTYzgEH0mvYPx8C73Q4wCHIxKPLwM9eYRQqyJZcWVuYcYJTiYlUR4A/YDhXhT EiurUovy44tKc1KLDzGaAu2fyCwlmpwPjJ+8knhDE3MTc2MDC3NLSxMjJXHextnPwoUE0hNL UrNTUwtSi2D6mDg4pRoYTT8pvfGoEy8sjbS4kf1n52YvbhE7x1OTWmf9XXVma8yWt85TT5Sy zH0f2FJtq7lC7eszCYf1kfJOW3b+nR7wba+jWG9IT8H+TQLFcvtKvgZktBU3mmzNnqe+xdr5 pFnXm912oX83ndJt+H5ARTtu0bnAmRfzV3N3nPzzL3PqieqbewwvVe1KUGIpzkg01GIuKk4E APmsTD1nAgAA X-MTR: 20000000000000000@CPGS Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 675 Lines: 22 v4l2_fh_init is already done.So call the v4l2_fh_exit in error condition before returing from the function. Signed-off-by: Shailendra Verma --- drivers/media/platform/omap3isp/ispvideo.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/platform/omap3isp/ispvideo.c b/drivers/media/platform/omap3isp/ispvideo.c index 7354469..2822e2f 100644 --- a/drivers/media/platform/omap3isp/ispvideo.c +++ b/drivers/media/platform/omap3isp/ispvideo.c @@ -1350,6 +1350,7 @@ static int isp_video_open(struct file *file) done: if (ret < 0) { v4l2_fh_del(&handle->vfh); + v4l2_fh_exit(&handle->vfh); kfree(handle); } -- 1.7.9.5