Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752695AbcKYEtX (ORCPT ); Thu, 24 Nov 2016 23:49:23 -0500 Received: from mailout3.samsung.com ([203.254.224.33]:51038 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750968AbcKYEtO (ORCPT ); Thu, 24 Nov 2016 23:49:14 -0500 X-AuditID: cbfee61a-f79916d0000062de-70-5837c2c8d741 From: Shailendra Verma To: Mauro Carvalho Chehab , Fabien Dessenne , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Shailendra Verma , Shailendra Verma Cc: vidushi.koul@samsung.com Subject: [PATCH] Media: Platform: Sti: Bdisp: - Fix for error handling Date: Fri, 25 Nov 2016 10:16:46 +0530 Message-id: <1480049206-20139-1-git-send-email-shailendra.v@samsung.com> X-Mailer: git-send-email 1.7.9.5 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrCLMWRmVeSWpSXmKPExsVy+t9jQd0Th8wjDDr2SVscW7ed0eLyrjls Fj0btrJaLNv0h8ni1ryZbBaLvr1itvh78RKbA7vHzll32T02repk8+jbsorR4+mPvcwenzfJ BbBGudlkpCampBYppOYl56dk5qXbKoWGuOlaKCnkJeam2ipF6PqGBCkplCXmlAJ5RgZowME5 wD1YSd8uwS3jdd9tpoKJbBVvZ9xlb2Ccz9rFyMEhIWAi8e11cBcjJ5ApJnHh3nq2LkYuDiGB WYwSS//3sUM4Pxklfi/eyghSxSZgKPG67y8TSEIEJDFzNkgLJwezgIzEvoltTCC2sICbxL8p n5hBbBYBVYntr9eB1fAKeEiceXkSarOCxJxJNhMYuRcwMqxilEgtSC4oTkrPNcxLLdcrTswt Ls1L10vOz93ECA7RZ1I7GA/ucj/EKMDBqMTDOyHdPEKINbGsuDL3EKMEB7OSCK/PQaAQb0pi ZVVqUX58UWlOavEhRlOg/ROZpUST84Hxk1cSb2hibmJubGBhbmlpYqQkzts4+1m4kEB6Yklq dmpqQWoRTB8TB6dUA6Mbz2arv2l/5Y7+VPmZ1N75WUFmTajWhOtZDS/zAsrOGpVJ7y62X3hP v1Twds6WvFtCjal27doPbBY8vVrtsSdK8f/2v8FxsvMWO/1fr1M25Xex58Qzyp7/Ndp+PlJs t808nek7dd2Ss3NFis4XBez746qpVZZlI/ks4hRX7P7X3VtuTMl9bKLEUpyRaKjFXFScCADB DmFkZwIAAA== X-MTR: 20000000000000000@CPGS Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 759 Lines: 24 The File handle is not yet added in the vdev list.So no need to call v4l2_fh_del(&ctx->fh)if it fails to create control. Signed-off-by: Shailendra Verma --- drivers/media/platform/sti/bdisp/bdisp-v4l2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/sti/bdisp/bdisp-v4l2.c b/drivers/media/platform/sti/bdisp/bdisp-v4l2.c index 45f82b5..fbf302f 100644 --- a/drivers/media/platform/sti/bdisp/bdisp-v4l2.c +++ b/drivers/media/platform/sti/bdisp/bdisp-v4l2.c @@ -632,8 +632,8 @@ static int bdisp_open(struct file *file) error_ctrls: bdisp_ctrls_delete(ctx); -error_fh: v4l2_fh_del(&ctx->fh); +error_fh: v4l2_fh_exit(&ctx->fh); bdisp_hw_free_nodes(ctx); mem_ctx: -- 1.7.9.5