Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752558AbcKYEys (ORCPT ); Thu, 24 Nov 2016 23:54:48 -0500 Received: from mailout4.samsung.com ([203.254.224.34]:51089 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751237AbcKYEyl (ORCPT ); Thu, 24 Nov 2016 23:54:41 -0500 X-AuditID: cbfee61a-f79916d0000062de-4f-5837c4090a1b From: Shailendra Verma To: Mauro Carvalho Chehab , Lad Prabhakar , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Shailendra Verma , Shailendra Verma Cc: vidushi.koul@samsung.com Subject: [PATCH] Staging: media: platform: davinci: - Fix for memory leak Date: Fri, 25 Nov 2016 10:22:04 +0530 Message-id: <1480049524-20460-1-git-send-email-shailendra.v@samsung.com> X-Mailer: git-send-email 1.7.9.5 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrHLMWRmVeSWpSXmKPExsVy+t9jQV3OI+YRBleuqVtc3jWHzaJnw1ZW i2Wb/jBZvLy/gtni1ryZbBaLvr1itvh78RKbA7vHzll32T02repk8+jbsorR4/MmuQCWKDeb jNTElNQihdS85PyUzLx0W6XQEDddCyWFvMTcVFulCF3fkCAlhbLEnFIgz8gADTg4B7gHK+nb JbhlLJp8nKXgClvFk6faDYznWLsYOTgkBEwkZv/U6GLkBDLFJC7cW8/WxcjFISQwi1Fi9vnz 7BDOT0aJg22NbCBVbAKGEq/7/jKBJEQEfjNKPJ2/jgUkwSwgI7FvYhsTiC0s4Cmxf/UaZhCb RUBVomd9C1gzr4CHxLWFO6A2K0jMmWQzgZF7ASPDKkaJ1ILkguKk9FzDvNRyveLE3OLSvHS9 5PzcTYzgsHwmtYPx4C73Q4wCHIxKPLwT0s0jhFgTy4orcw8xSnAwK4nw+hwECvGmJFZWpRbl xxeV5qQWH2I0Bdo/kVlKNDkfGDN5JfGGJuYm5sYGFuaWliZGSuK8jbOfhQsJpCeWpGanphak FsH0MXFwSjUwuszmO9O+Wa3WtG8ngxLPB8FLnRdufWrKzglL/f1jnkzBhG2mgs+mVWaxXZQW iDv4c2abyWLjrY253RuVF9s/W6Ne8bW/smy69oqk6Tf1z7i+bPCNaWibWqDCf2aZMlt4mbKq 9EffEz6Ll968Gni/YZPu6VtTohS9rmZu+CO2O6qCT+db4JknSizFGYmGWsxFxYkARZSJVWEC AAA= X-MTR: 20000000000000000@CPGS Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 826 Lines: 24 Fix to avoid possible memory leak if the decoder initialization got failed. Free the allocated memory for file handle object before return in case decoder initialization fails. Signed-off-by: Shailendra Verma --- drivers/media/platform/davinci/vpfe_capture.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/platform/davinci/vpfe_capture.c b/drivers/media/platform/davinci/vpfe_capture.c index 6efb2f1..188b333 100644 --- a/drivers/media/platform/davinci/vpfe_capture.c +++ b/drivers/media/platform/davinci/vpfe_capture.c @@ -526,6 +526,8 @@ static int vpfe_open(struct file *file) if (!vpfe_dev->initialized) { if (vpfe_initialize_device(vpfe_dev)) { mutex_unlock(&vpfe_dev->lock); + v4l2_fh_exit(&fh->fh); + kfree(fh); return -ENODEV; } } -- 1.7.9.5