Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751569AbcKYFLd (ORCPT ); Fri, 25 Nov 2016 00:11:33 -0500 Received: from mailout1.samsung.com ([203.254.224.24]:46496 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750764AbcKYFL3 (ORCPT ); Fri, 25 Nov 2016 00:11:29 -0500 X-AuditID: cbfee61b-f796f6d000004092-e8-5837c7f7120a From: Shailendra Verma To: Mauro Carvalho Chehab , Laurent Pinchart , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Shailendra Verma , Shailendra Verma Cc: vidushi.koul@samsung.com Subject: [PATCH] Media: platform: vsp1: - Do not forget to call Date: Fri, 25 Nov 2016 10:37:57 +0530 Message-id: <1480050477-21189-1-git-send-email-shailendra.v@samsung.com> X-Mailer: git-send-email 1.7.9.5 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrBLMWRmVeSWpSXmKPExsVy+t9jAd3vx80jDNbtl7XonLiE3eLyrjls Fj0btrJabH35jsli2aY/TBa35s1ks1j07RWzxd+Ll9gcODx2zrrL7jG7Yyarx6ZVnWwefVtW MXp83iQXwBrlZpORmpiSWqSQmpecn5KZl26rFBripmuhpJCXmJtqqxSh6xsSpKRQlphTCuQZ GaABB+cA92AlfbsEt4zb+w8yFuxhrVjx8j5LA+NZli5GTg4JAROJ3b8vM0PYYhIX7q1n62Lk 4hASWMoo8efMESjnJ6PEsuPNYB1sAoYSr/v+MoHYIgJrmCR6bwqB2MwCMhL7JrYBxTk4hAXs JaZPywQJswioSrx9uwlsAa+Ah0TT3vOMICUSAgoScybZTGDkXsDIsIpRIrUguaA4KT3XKC+1 XK84Mbe4NC9dLzk/dxMjOFSfSe9gPLzL/RCjAAejEg/vCmAIC7EmlhVX5h5ilOBgVhLh9TkI FOJNSaysSi3Kjy8qzUktPsRoCrR/IrOUaHI+MI7ySuINTcxNzI0NLMwtLU2MlMR5G2c/CxcS SE8sSc1OTS1ILYLpY+LglGpglL3U/VpDacqUGat0vLh4t52R9vMTPn7rLJsCy6LTPld8G9iv lW2bE/r70sewrofBMg0Pc52P/fj9IDzgV9jv3ujFj2xsDj7t/bvCS/DaassYhvDdjhem/BQ/ PPF84+Wtl7vzuMID//1qf7KMI+vvpc2f1+TNFo1UaXt/jzVe6BKL8NYVGYmNT5RYijMSDbWY i4oTAR6caUprAgAA X-MTR: 20000000000000000@CPGS Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 676 Lines: 22 v4l2_fh_init is already done.So call the v4l2_fh_exit in error condition before returing from the function. Signed-off-by: Shailendra Verma --- drivers/media/platform/vsp1/vsp1_video.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/platform/vsp1/vsp1_video.c b/drivers/media/platform/vsp1/vsp1_video.c index d351b9c..cc58163 100644 --- a/drivers/media/platform/vsp1/vsp1_video.c +++ b/drivers/media/platform/vsp1/vsp1_video.c @@ -1044,6 +1044,7 @@ static int vsp1_video_open(struct file *file) ret = vsp1_device_get(video->vsp1); if (ret < 0) { v4l2_fh_del(vfh); + v4l2_fh_exit(vfh); kfree(vfh); } -- 1.7.9.5