Date: Fri, 25 Nov 2016 00:48:22 -0500
From: Jessica Yu <jeyu@redhat.com>
To: rusty@rustcorp.com.au, AKASHI Takahiro <takahiro.akashi@linaro.org>
Cc: mark.rutland@arm.com, keescook@chromium.org,
        kernel-hardening@lists.openwall.com, linux-kernel@vger.kernel.org
Subject: Re: module: extend 'rodata=off' boot cmdline parameter to module
 mappings
Message-ID: <20161125054822.GA2793@packer-debian-8-amd64.digitalocean.com>
References: <20161114061505.15238-1-takahiro.akashi@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <20161114061505.15238-1-takahiro.akashi@linaro.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 949
Lines: 24

+++ AKASHI Takahiro [14/11/16 15:15 +0900]:
>The current "rodata=off" parameter disables read-only kernel mappings
>under CONFIG_DEBUG_RODATA:
>    commit d2aa1acad22f ("mm/init: Add 'rodata=off' boot cmdline parameter
>    to disable read-only kernel mappings")
>
>This patch is a logical extension to module mappings ie. read-only mappings
>at module loading can be disabled even if CONFIG_DEBUG_SET_MODULE_RONX
>(mainly for debug use). Please note, however, that it only affects RO/RW
>permissions, keeping NX set.
>
>This is the first step to make CONFIG_DEBUG_SET_MODULE_RONX mandatory
>(always-on) in the future as CONFIG_DEBUG_RODATA on x86 and arm64.
>
>Suggested-by: and Acked-by: Mark Rutland <mark.rutland@arm.com>
>Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
>Reviewed-by: Kees Cook <keescook@chromium.org>
>Cc: Rusty Russell <rusty@rustcorp.com.au>

Hi Rusty, could I get an (n)ack for this patch? :-)

Thanks!

Jessica