Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752404AbcKYH3y (ORCPT ); Fri, 25 Nov 2016 02:29:54 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:41674 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750995AbcKYH3p (ORCPT ); Fri, 25 Nov 2016 02:29:45 -0500 X-AuditID: cbfee61a-f79916d0000062de-1c-5837e867833f Message-id: <5837E893.1020409@samsung.com> Date: Fri, 25 Nov 2016 16:30:27 +0900 From: Joonyoung Shim User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-version: 1.0 To: Viresh Kumar Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, vireshk@kernel.org, nm@ti.com, sboyd@codeaurora.org, rjw@rjwysocki.net, len.brown@intel.com, pavel@ucw.cz, gregkh@linuxfoundation.org Subject: Re: [PATCH] PM / OPP: fix CPU device to be removed from OPP table in wrong order References: <1479973761-21225-1-git-send-email-jy0922.shim@samsung.com> <20161124083403.GA29969@vireshk-i7> <583799EC.4060101@samsung.com> <20161125065739.GC29969@vireshk-i7> In-reply-to: <20161125065739.GC29969@vireshk-i7> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrCIsWRmVeSWpSXmKPExsVy+t9jQd30F+YRBpv3alo0L17PZjFryl4m i8u75rBZfO49wmjx5sdZJou7p46yWZw5fYnV4seZbhaLjV89LDY/OMbmwOVxua+XyWPxnpdM HptWdbJ53Lm2h81j/9w17B5brrazeBy/sZ3JY8Xq7+wenzfJBXBGudlkpCampBYppOYl56dk 5qXbKoWGuOlaKCnkJeam2ipF6PqGBCkplCXmlAJ5RgZowME5wD1YSd8uwS3j3qOdzAWNAhVN reeYGxjX8XQxcnJICJhIbJ84lR3CFpO4cG89WxcjF4eQwCxGieWLV4IlhATuM0rsO8AHYvMK aEk82/GLGcRmEVCV2HP5FiuIzSagJ3Fn23EmEFtUIEziwbq9rBD1ghI/Jt9j6WLk4BAB6n15 MxVkPrPAUUaJ2avOsIHUCAtES0w61sEOsbiNSWJ5yzFWkAZOAQOJvb/CQExmoPn3L2qBlDML yEtsXvOWeQIj0JEIG2YhVM1CUrWAkXkVo0RqQXJBcVJ6rmFearlecWJucWleul5yfu4mRnCM PpPawXhwl/shRgEORiUe3gnp5hFCrIllxZW5hxglOJiVRHgZngKFeFMSK6tSi/Lji0pzUosP MZoCg2Ais5Rocj4wfeSVxBuamJuYGxtYmFtamhgpifM2zn4WLiSQnliSmp2aWpBaBNPHxMEp 1cA4Nfvf/zclR1O+2h0J3//H9/GZo33bE6afu2/g6yCbFRru1rxj98bMZQntnrqKHzezHvvs fWzyjIrg1WJbviyz+pw68cPr7IoXZtoW2R9Sp7JpGnJU/5ULnTdJ8O8SPQOX2NcNsq6Hbz9f udaP0bfp/Dxx5Xl6ikIvUo4ptHvdsvG9J6rLGsKpxFKckWioxVxUnAgAQljOKucCAAA= X-MTR: 20000000000000000@CPGS Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1996 Lines: 53 Hi Viresh, On 11/25/2016 03:57 PM, Viresh Kumar wrote: > On 25-11-16, 10:54, Joonyoung Shim wrote: >> I found this problem during system suspend/resume of Odroid-XU3 board. >> >> # rtcwake -m mem -s 3 >> wakeup from "mem" at Wed Apr 4 05:54:44 2001 >> [ 15.965996] PM: Syncing filesystems ... done. >> [ 15.976333] Freezing user space processes ... (elapsed 0.002 seconds) done. >> [ 15.983287] Freezing remaining freezable tasks ... (elapsed 0.002 seconds) done. >> [ 16.006951] wake enabled for irq 135 >> [ 16.008782] smsc95xx 1-1.1:1.0 eth0: entering SUSPEND2 mode >> [ 16.094110] PM: suspend of devices complete after 95.038 msecs >> [ 16.105648] PM: late suspend of devices complete after 6.903 msecs >> [ 16.116356] PM: noirq suspend of devices complete after 5.912 msecs >> [ 16.121213] Disabling non-boot CPUs ... >> [ 16.154140] IRQ51 no longer affine to CPU1 >> [ 16.154709] CPU1: shutdown >> [ 16.214148] IRQ52 no longer affine to CPU2 >> [ 16.214646] CPU2: shutdown >> [ 16.273980] IRQ53 no longer affine to CPU3 >> [ 16.274458] CPU3: shutdown >> [ 16.335093] IRQ54 no longer affine to CPU4 >> [ 16.336033] CPU4: shutdown >> [ 16.389979] IRQ55 no longer affine to CPU5 >> [ 16.390823] CPU5: shutdown >> [ 16.444829] IRQ56 no longer affine to CPU6 >> [ 16.445621] CPU6: shutdown >> [ 16.509229] cpu cpu4: Failed to find opp_table: -19 >> [ 16.514008] IRQ57 no longer affine to CPU7 >> [ 16.514824] CPU7: shutdown > > Hi, > > Yes you have found a real bug it seems. I think that can be reproduced > by a simple rmmmod of cpufreq-dt.ko module as well. > > Though the solution you provided isn't good enough. > > Consider for example a case where you do this: > - offline CPU 4 > - suspend the system > > You are going to get stuck in the exact same problem again. > > I have sent a separate patch and cc'd you. Can you please verify that > it works for you ? > Thanks for the patch, i tested it and it is working well. Thanks.