MIME-Version: 1.0
In-Reply-To: <20161124163158.3939337-1-arnd@arndb.de>
References: <20161124163158.3939337-1-arnd@arndb.de>
From: Vitaly Wool <vitalywool@gmail.com>
Date: Fri, 25 Nov 2016 08:35:47 +0100
Message-ID: <CAMJBoFPTTTKCNYDH+HkFz_7PykMSKvh1HgtvUOR2u29cjb2fgA@mail.gmail.com>
Subject: Re: [PATCH] z3fold: use %z modifier for format string
To: Arnd Bergmann <arnd@arndb.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
        Dan Streetman <ddstreet@ieee.org>, zhong jiang <zhongjiang@huawei.com>,
        Linux-MM <linux-mm@kvack.org>, LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Transfer-Encoding: 8bit
Content-Length: 1308
Lines: 37

Hi Arnd,

On Thu, Nov 24, 2016 at 5:31 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> Printing a size_t requires the %zd format rather than %d:
>
> mm/z3fold.c: In function ‘init_z3fold’:
> include/linux/kern_levels.h:4:18: error: format ‘%d’ expects argument of type ‘int’, but argument 2 has type ‘long unsigned int’ [-Werror=format=]
>
> Fixes: 50a50d2676c4 ("z3fold: don't fail kernel build if z3fold_header is too big")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Acked-by: Vitaly Wool <vitalywool@gmail.com>

And thanks :)

~vitaly

> ---
>  mm/z3fold.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/z3fold.c b/mm/z3fold.c
> index e282ba073e77..66ac7a7dc934 100644
> --- a/mm/z3fold.c
> +++ b/mm/z3fold.c
> @@ -884,7 +884,7 @@ static int __init init_z3fold(void)
>  {
>         /* Fail the initialization if z3fold header won't fit in one chunk */
>         if (sizeof(struct z3fold_header) > ZHDR_SIZE_ALIGNED) {
> -               pr_err("z3fold: z3fold_header size (%d) is bigger than "
> +               pr_err("z3fold: z3fold_header size (%zd) is bigger than "
>                         "the chunk size (%d), can't proceed\n",
>                         sizeof(struct z3fold_header) , ZHDR_SIZE_ALIGNED);
>                 return -E2BIG;
> --
> 2.9.0
>