Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752885AbcKYHvQ (ORCPT ); Fri, 25 Nov 2016 02:51:16 -0500 Received: from protonic.xs4all.nl ([83.163.252.89]:20486 "EHLO protonic.xs4all.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752758AbcKYHvH (ORCPT ); Fri, 25 Nov 2016 02:51:07 -0500 Date: Fri, 25 Nov 2016 08:50:04 +0100 From: Robin van der Gracht To: Arnd Bergmann Cc: Greg Kroah-Hartman , Rob Herring , Linus Walleij , Miguel Ojeda Sandonis , linux-kernel@vger.kernel.org Subject: Re: [PATCH] auxdisplay: ht16k33: select CONFIG_FB_SYS_FOPS Message-ID: <20161125085004.74c9acb5@erd979> In-Reply-To: <20161123130702.432411-1-arnd@arndb.de> References: <20161123130702.432411-1-arnd@arndb.de> Organization: Protonic Holland X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1512 Lines: 53 Hi Arnd, On Wed, 23 Nov 2016 14:06:49 +0100 Arnd Bergmann wrote: > The new driver caused a rare randconfig failure: > > drivers/auxdisplay/ht16k33.o:(.data.ht16k33_fb_ops+0xc): undefined reference to `fb_sys_read' > drivers/auxdisplay/ht16k33.o:(.data.ht16k33_fb_ops+0x10): undefined reference to `fb_sys_write' > > This selects the respective helper module, like all other > such drivers do. Thanks for reporting this. You are right about the missing helper. However, the fb_ops struct uses several helpers which are all missing. static struct fb_ops ht16k33_fb_ops = { .owner = THIS_MODULE, .fb_read = fb_sys_read, .fb_write = fb_sys_write, .fb_fillrect = sys_fillrect, .fb_copyarea = sys_copyarea, .fb_imageblit = sys_imageblit, .fb_mmap = ht16k33_mmap, }; HT16K33 should also select: FB_CFB_FILLRECT FB_CFB_COPYAREA FB_CFB_IMAGEBLIT > > Fixes: 8992da44c680 ("auxdisplay: ht16k33: Driver for LED controller") > Signed-off-by: Arnd Bergmann > --- > drivers/auxdisplay/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/auxdisplay/Kconfig b/drivers/auxdisplay/Kconfig > index a230ea797b92..b8bbfc64a1d1 100644 > --- a/drivers/auxdisplay/Kconfig > +++ b/drivers/auxdisplay/Kconfig > @@ -131,6 +131,7 @@ config IMG_ASCII_LCD > config HT16K33 > tristate "Holtek Ht16K33 LED controller with keyscan" > depends on FB && OF && I2C && INPUT > + select FB_SYS_FOPS > select INPUT_MATRIXKMAP > select FB_BACKLIGHT > help Regards, Robin