Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751708AbcKYILZ (ORCPT ); Fri, 25 Nov 2016 03:11:25 -0500 Received: from mga09.intel.com ([134.134.136.24]:40377 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751075AbcKYILS (ORCPT ); Fri, 25 Nov 2016 03:11:18 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,546,1473145200"; d="scan'208";a="1090222716" Date: Fri, 25 Nov 2016 10:11:11 +0200 From: Jarkko Sakkinen To: Stefan Berger Cc: Nayna Jain , linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, tpmdd-devel@lists.sourceforge.net Subject: Re: [tpmdd-devel] [PATCH v5 3/3] tpm: add securityfs support for TPM 2.0 firmware event log Message-ID: <20161125081111.qkfqfmtpkobsiu2a@intel.com> References: <1479922057-8752-1-git-send-email-nayna@linux.vnet.ibm.com> <1479922057-8752-4-git-send-email-nayna@linux.vnet.ibm.com> <20161124211057.xynmfteky5r7uc27@intel.com> <11f97863-aa40-a9aa-836f-4b446faf1ed3@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <11f97863-aa40-a9aa-836f-4b446faf1ed3@linux.vnet.ibm.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1315 Lines: 30 On Thu, Nov 24, 2016 at 09:51:03PM -0500, Stefan Berger wrote: > On 11/24/2016 04:10 PM, Jarkko Sakkinen wrote: > > On Wed, Nov 23, 2016 at 12:27:37PM -0500, Nayna Jain wrote: > > > Unlike the device driver support for TPM 1.2, the TPM 2.0 does > > > not support the securityfs pseudo files for displaying the > > > firmware event log. > > > > > > This patch enables support for providing the TPM 2.0 event log in > > > binary form. TPM 2.0 event log supports a crypto agile format that > > > records multiple digests, which is different from TPM 1.2. This > > > patch enables the tpm_bios_log_setup for TPM 2.0 and adds the > > > event log parser which understand the TPM 2.0 crypto agile format. > > > > > > Signed-off-by: Nayna Jain > > I don't want to say much about this before I've tested it. I wonder > > what cheap hardware I could use to test this. Any advice is on this > > from anyone is much appreciated. > > Virtual hardware would be cheap :-) > > I tested this series with QEMU + vTPM + SeaBIOS with TPM 1.2 + TPM 2 support > (basing the log on ACPI). I had to fix an endianess issue on the SeaBIOS > side, which made it work. So for this version of the patches I can give it > my tested-by: > > Tested-by: Stefan Berger Thanks. /Jarkko