Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754194AbcKYIsL (ORCPT ); Fri, 25 Nov 2016 03:48:11 -0500 Received: from szxga02-in.huawei.com ([119.145.14.65]:21648 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754159AbcKYIr4 (ORCPT ); Fri, 25 Nov 2016 03:47:56 -0500 From: Jiancheng Xue To: CC: , , , , , Subject: [PATCH] reset: ti_syscon: fix a ti_syscon_reset_status issue Date: Fri, 25 Nov 2016 16:29:37 +0800 Message-ID: <1480062577-11505-1-git-send-email-xuejiancheng@hisilicon.com> X-Mailer: git-send-email 1.9.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.67.212.71] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 925 Lines: 28 If STATUS_SET is not set, ti_syscon_reset_status always returned 0 no matter the status_bit is set or not. Signed-off-by: Jiancheng Xue --- drivers/reset/reset-ti-syscon.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) mode change 100644 => 100755 drivers/reset/reset-ti-syscon.c diff --git a/drivers/reset/reset-ti-syscon.c b/drivers/reset/reset-ti-syscon.c old mode 100644 new mode 100755 index 47f0ffd..82769ff --- a/drivers/reset/reset-ti-syscon.c +++ b/drivers/reset/reset-ti-syscon.c @@ -154,8 +154,8 @@ static int ti_syscon_reset_status(struct reset_controller_dev *rcdev, if (ret) return ret; - return (reset_state & BIT(control->status_bit)) && - (control->flags & STATUS_SET); + ret = (reset_state & BIT(control->status_bit)) ? 1 : 0; + return (control->flags & STATUS_SET) ? ret : (!ret); } static struct reset_control_ops ti_syscon_reset_ops = { -- 1.9.1