Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754161AbcKYMmR (ORCPT ); Fri, 25 Nov 2016 07:42:17 -0500 Received: from pb-sasl1.pobox.com ([64.147.108.66]:54578 "EHLO sasl.smtp.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754040AbcKYMmJ (ORCPT ); Fri, 25 Nov 2016 07:42:09 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=subject:to :references:cc:from:message-id:date:mime-version:in-reply-to :content-type:content-transfer-encoding; q=dns; s=sasl; b=A84lwx Mg9Lr+Nfccu/sZjNSQLhKPMhfPZswl7Z0ezJQS6BwIN0IRwY5bypIIWuYO28229E t4kaXRG35Pkc1LIp1XhpbriYtecqMnPCzcb1u0V+9AsD45/vJTwyZI7QTuvQWBSD WQBRQRaRK5yy0W6l/tPrQjrJDB2Yo3gt57OJU= Subject: Re: [PATCH net 1/2] r8152: fix the sw rx checksum is unavailable To: Hayes Wang , "netdev@vger.kernel.org" References: <1394712342-15778-226-Taiwan-albertk@realtek.com> <1394712342-15778-227-Taiwan-albertk@realtek.com> <0835B3720019904CB8F7AA43166CEEB20105013E@RTITMBSV03.realtek.com.tw> <0835B3720019904CB8F7AA43166CEEB201050B7E@RTITMBSV03.realtek.com.tw> <0835B3720019904CB8F7AA43166CEEB2010517CE@RTITMBSV03.realtek.com.tw> <0835B3720019904CB8F7AA43166CEEB201051D51@RTITMBSV03.realtek.com.tw> <95fa9f67-3af6-6749-0e2b-c95406486f7d@pobox.com> <0835B3720019904CB8F7AA43166CEEB201055ED8@RTITMBSV03.realtek.com.tw> <0835B3720019904CB8F7AA43166CEEB201056266@RTITMBSV03.realtek.com.tw> Cc: nic_swsd , "linux-kernel@vger.kernel.org" , "linux-usb@vger.kernel.org" From: Mark Lord Message-ID: <94f1ef0f-2a48-099c-d91f-7057fb474a27@pobox.com> Date: Fri, 25 Nov 2016 07:36:57 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <0835B3720019904CB8F7AA43166CEEB201056266@RTITMBSV03.realtek.com.tw> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Pobox-Relay-ID: DB556784-B30B-11E6-A7FE-B2316462E9F6-82205200!pb-sasl1.pobox.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 404 Lines: 13 On 16-11-25 01:11 AM, Hayes Wang wrote: > Mark Lord [mailto:mlord@pobox.com] .. >> If that "return 0" statement is ever executed, doesn't it result >> in the loss/leak of a buffer? > > They would be found back by calling rtl_start_rx(), when the rx > is restarted. Good. I figured it was probably something like that, but wasn't entirely sure about the control flow around stop/restart there. Thanks.