Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754348AbcKYNEx (ORCPT ); Fri, 25 Nov 2016 08:04:53 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:44400 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752822AbcKYNEY (ORCPT ); Fri, 25 Nov 2016 08:04:24 -0500 Date: Fri, 25 Nov 2016 13:03:37 +0000 From: Mark Brown To: Nicolae Rosia Cc: Liam Girdwood , Tony Lindgren , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: <20161125130337.lf33cysb4cyq6axl@sirena.org.uk> References: <20161125074335.6947-1-Nicolae_Rosia@mentor.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="vnrhmoke6rdzhnoo" Content-Disposition: inline In-Reply-To: <20161125074335.6947-1-Nicolae_Rosia@mentor.com> X-Cookie: rugged, adj.: User-Agent: NeoMutt/20161014 (1.7.1) X-SA-Exim-Connect-IP: 2001:470:1f1d:6b5::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH] regulator: twl6030: add dependency on OF X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: No (on mezzanine.sirena.org.uk); Unknown failure Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1620 Lines: 49 --vnrhmoke6rdzhnoo Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Nov 25, 2016 at 09:43:35AM +0200, Nicolae Rosia wrote: > This driver was converted to device tree only, > add dependency on OF symbol and drop of_match_ptr These are two different changes :( > config REGULATOR_TWL4030 > tristate "TI TWL4030/TWL5030/TWL6030/TPS659x0 PMIC" > depends on TWL4030_CORE > + depends on OF This should be OF || COMPILE_TEST so people can still get build coverage without DT. > --- a/drivers/regulator/twl6030-regulator.c > +++ b/drivers/regulator/twl6030-regulator.c > @@ -773,7 +773,7 @@ static struct platform_driver twlreg_driver = { > */ > .driver = { > .name = "twl6030_reg", > - .of_match_table = of_match_ptr(twl_of_match), > + .of_match_table = twl_of_match, This buys us nothing, it's not going to make any practical difference but on the other hand it costs nothing to have it there either. The only impact I can see this having is causing someone doing a cut'n'paste to miss the of_match_ptr() out. --vnrhmoke6rdzhnoo Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAABCAAGBQJYODaoAAoJECTWi3JdVIfQAwoH+wXpjbf7g6c+APA3bPpR8nvq 9M+IXclJrFLchd/APvm+hvNPC66+6sj/OwGu8hRidHzU4751LGC8ICHa5kBR0sOp cd+/hu9iSs30SY0W8XAEPChELc8F34eGFAab5VgVCRs48CQeUR++x75CJvVfWFFt DCg662zQhPZxGfw3zdXdne4ZmifrNW74OiOzii6cRBKAtPehfuGmDZQprEADMn3/ p3w4CixU0JfjwBfcYP+V4kjqA3cRzXe+iewiDGAJ9OFkES0QeDi+vSBWLfG/uf8J 9M1//3gkALiOd21p9rs3HK9/Mgvr1idTb7QxYpxrHFO59b8tjbirIvl5JIsuk/g= =MagU -----END PGP SIGNATURE----- --vnrhmoke6rdzhnoo--