Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754503AbcKYNLp (ORCPT ); Fri, 25 Nov 2016 08:11:45 -0500 Received: from mail-io0-f193.google.com ([209.85.223.193]:35401 "EHLO mail-io0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753257AbcKYNLh (ORCPT ); Fri, 25 Nov 2016 08:11:37 -0500 MIME-Version: 1.0 In-Reply-To: <20161125130337.lf33cysb4cyq6axl@sirena.org.uk> References: <20161125074335.6947-1-Nicolae_Rosia@mentor.com> <20161125130337.lf33cysb4cyq6axl@sirena.org.uk> From: Nicolae Rosia Date: Fri, 25 Nov 2016 15:09:43 +0200 Message-ID: Subject: Re: [PATCH] regulator: twl6030: add dependency on OF To: Mark Brown Cc: Nicolae Rosia , Liam Girdwood , Tony Lindgren , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1307 Lines: 41 Hi, On Fri, Nov 25, 2016 at 3:03 PM, Mark Brown wrote: > On Fri, Nov 25, 2016 at 09:43:35AM +0200, Nicolae Rosia wrote: > >> This driver was converted to device tree only, >> add dependency on OF symbol and drop of_match_ptr > > These are two different changes :( > Ok, will send a patch only for Kconfig. >> config REGULATOR_TWL4030 >> tristate "TI TWL4030/TWL5030/TWL6030/TPS659x0 PMIC" >> depends on TWL4030_CORE >> + depends on OF > > This should be OF || COMPILE_TEST so people can still get build coverage > without DT. > Ok. >> --- a/drivers/regulator/twl6030-regulator.c >> +++ b/drivers/regulator/twl6030-regulator.c >> @@ -773,7 +773,7 @@ static struct platform_driver twlreg_driver = { >> */ >> .driver = { >> .name = "twl6030_reg", >> - .of_match_table = of_match_ptr(twl_of_match), >> + .of_match_table = twl_of_match, > > This buys us nothing, it's not going to make any practical difference > but on the other hand it costs nothing to have it there either. The > only impact I can see this having is causing someone doing a cut'n'paste > to miss the of_match_ptr() out. I did this because I received a comment on another patch [0]. Thanks, Nicolae [0] https://patchwork.ozlabs.org/patch/694021/