Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753974AbcKYNSH (ORCPT <rfc822;w@1wt.eu>);
        Fri, 25 Nov 2016 08:18:07 -0500
Received: from mezzanine.sirena.org.uk ([106.187.55.193]:45474 "EHLO
        mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751634AbcKYNSD (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 25 Nov 2016 08:18:03 -0500
Date: Fri, 25 Nov 2016 13:17:55 +0000
From: Mark Brown <broonie@kernel.org>
To: Nicolae Rosia <nicolae.rosia.oss@gmail.com>
Cc: Nicolae Rosia <Nicolae_Rosia@mentor.com>,
        Liam Girdwood <lgirdwood@gmail.com>, Tony Lindgren <tony@atomide.com>,
        linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org
Message-ID: <20161125131755.7qbtcbjwjeuff4og@sirena.org.uk>
References: <20161125074335.6947-1-Nicolae_Rosia@mentor.com>
 <20161125130337.lf33cysb4cyq6axl@sirena.org.uk>
 <CAKP5S=1Ds0-cz7qHiRbLPQj2e0fwaPXFExhRBcZ5qMkWUTaumA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="ex6ppfvob2mqvipi"
Content-Disposition: inline
In-Reply-To: <CAKP5S=1Ds0-cz7qHiRbLPQj2e0fwaPXFExhRBcZ5qMkWUTaumA@mail.gmail.com>
X-Cookie: rugged, adj.:
User-Agent: NeoMutt/20161014 (1.7.1)
X-SA-Exim-Connect-IP: 2001:470:1f1d:6b5::3
X-SA-Exim-Mail-From: broonie@sirena.org.uk
Subject: Re: [PATCH] regulator: twl6030: add dependency on OF
X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000)
X-SA-Exim-Scanned: No (on mezzanine.sirena.org.uk); Unknown failure
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1296
Lines: 35


--ex6ppfvob2mqvipi
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Nov 25, 2016 at 03:09:43PM +0200, Nicolae Rosia wrote:
> On Fri, Nov 25, 2016 at 3:03 PM, Mark Brown <broonie@kernel.org> wrote:

> >> -             .of_match_table = of_match_ptr(twl_of_match),
> >> +             .of_match_table = twl_of_match,

> > This buys us nothing, it's not going to make any practical difference
> > but on the other hand it costs nothing to have it there either.  The
> > only impact I can see this having is causing someone doing a cut'n'paste
> > to miss the of_match_ptr() out.

> I did this because I received a comment on another patch [0].

OK, but that still doesn't really explain what the benefit is!

--ex6ppfvob2mqvipi
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEcBAABCAAGBQJYODoCAAoJECTWi3JdVIfQXqkH/iJ3ugd19D9emT0/hdtbN8n4
KGt/CpxkvCF/3mVhwjgLvsDxBquODN4v82bc48Xw2Xj7G4h6haE8HYqZwukp5869
npQ9y0eD15OQQlGhZoAx8MctphEQeE+xgeTrWXseOQ2vK5KeL9tOaNPC8HB1ZBSD
7A2AyA7x37E9VvimO7Gw2+u4vizu/nJgtrmj/kwVb9WpKnSaJf9gWoRJfNpuKC4/
KC0g7cZSSGYHUuKtlaaqj9unTa18io+555YfaAGakZEpRbaQ74oFxH9M6DyTuaDU
OAcHB9zaSxAx+rxt/cZqUJI1s6Py86tWhNdyKlCWzGNjNCyUefcwkSe2olbB5rY=
=15b+
-----END PGP SIGNATURE-----

--ex6ppfvob2mqvipi--