Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755680AbcKYTYZ (ORCPT ); Fri, 25 Nov 2016 14:24:25 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:37929 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754333AbcKYTYP (ORCPT ); Fri, 25 Nov 2016 14:24:15 -0500 Date: Fri, 25 Nov 2016 20:28:47 +0100 From: Quentin Casasnovas To: Quentin Casasnovas Cc: Miklos Szeredi , linux-kernel@vger.kernel.org, Al Viro Subject: Re: [PATCH] ovl: tentative fix for broken vfs_open() on stacked overlayfs. Message-ID: <20161125192847.GH6842@chrystal.oracle.com> References: <20161125145604.GG6842@chrystal.oracle.com> <20161125170923.21674-1-quentin.casasnovas@oracle.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="xHbokkKX1kTiQeDC" Content-Disposition: inline In-Reply-To: <20161125170923.21674-1-quentin.casasnovas@oracle.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1826 Lines: 53 --xHbokkKX1kTiQeDC Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Nov 25, 2016 at 06:09:23PM +0100, Quentin Casasnovas wrote: > If two overlayfs filesystems are stacked on top of each other, then we ne= ed > to recurse when opening a file. This used to work and was first broken b= y: >=20 > 4bacc9c9234c ("overlayfs: Make f_path always point to the overlay...") >=20 > and fixed by: >=20 > 1c8a47df36d7 ("ovl: fix open in stacked overlay") >=20 > But it looks like it was re-introduced in: >=20 > 2d902671ce1c ("vfs: merge .d_select_inode() into .d_real()") >=20 > I know close to nothing about VFS/overlayfs And indeed I've proven it here - this tentative patch doesn't work for the general case, it just fixes the simple test case embedded in the commit description. Any help appreciated! Q --xHbokkKX1kTiQeDC Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- iQIcBAEBCgAGBQJYOJDpAAoJEB5Tt01po9cNQ/gP/1IIumJq6dDE+G04onIaWik2 QzbbsJSCb3BTQ+Gnh/WvVvX3zZCSbyLcBmPUamFuXkfck79WcoXHZuBolLfq6P4W ldZKRKXc3gB5Y2HqD5DW2523ZP5HuV3Nveb2v6vlKBSgyTliVBCzFJeyMnVywpMx FWBJH4TjPLVD8+8YIcIzPebL/8bXnyjoqC69i0X7KR4IIr1iIWokNObnkIEWOAe1 v43mhwrYchoa18fYb5UhdFighoZ0bsz1hbSSnV8B3ur2qZnZfkQUEbuEK0OXjwOK SMrO+m+fUi42RIxFCePbwYKN9FqvTKkpYZI33ZUPKWu3gVMQZ3JiipTxLekC15/V c6oD55KOcU5/VBmAKRbZ8+EXBd/CVTw6xkguV/1FGlraq+PbH3P2FaSGeUnX5cue xkA1+KNrTEfHvEWgTr0I13rlM5kHBtdKwzwclvwf+pdsZxZe/X7q312x10cuu0nn dmc+6CkkHKw5QgYX2Wdt1Q8/zJ+sylsufOUE2Z59eQDdsu/iQux9U8QtoxxBPsxO NwDhahrXZhf8nKyY5JS32v/iM97bnJW1FSMVTEt7ajzB2QMgdBDGGxJ7inD79Gb1 JrXldiNDW8X7dQkN9VCBWVmCbvBqFfQJ+mHl779OWyfac4vL5LhwA/oGrnxLgknz Rv08cF0NuCxqzq/WGoSB =IliC -----END PGP SIGNATURE----- --xHbokkKX1kTiQeDC--