Date: Sat, 26 Nov 2016 14:15:42 +0100
From: Pavel Machek <pavel@ucw.cz>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Grzegorz Andrejczuk <grzegorz.andrejczuk@intel.com>, mingo@redhat.com,
        hpa@zytor.com, x86@kernel.org, bp@suse.de, dave.hansen@linux.intel.com,
        lukasz.daniluk@intel.com, james.h.cownie@intel.com,
        jacob.jun.pan@intel.com, Piotr.Luc@intel.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6: 2/4] x86: Add enabling of the R3MWAIT during boot
Message-ID: <20161126131542.GB20568@xo-6d-61-c0.localdomain>
References: <1477576923-3244-1-git-send-email-grzegorz.andrejczuk@intel.com>
 <1477576923-3244-3-git-send-email-grzegorz.andrejczuk@intel.com>
 <alpine.DEB.2.20.1610271625410.4817@nanos>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.20.1610271625410.4817@nanos>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 702
Lines: 19

On Thu 2016-10-27 16:38:13, Thomas Gleixner wrote:
> On Thu, 27 Oct 2016, Grzegorz Andrejczuk wrote:
> > +#ifdef CONFIG_X86_64
> > +static int phi_r3mwait_disabled __read_mostly;
> > +
> > +static int __init phir3mwait_disable(char *__unused)
> > +{
> > +	phi_r3mwait_disabled = 1;
> > +	pr_warn("x86/phir3mwait: Disabled ring 3 MWAIT for Xeon Phi");
> 
> Why would that be a warning? The sysadmin added the command line switch, so
> why does he needs to be warned?

Its telling admin he did not make a typo on the command line. We often do that....

									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html