Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751524AbcKZNXz (ORCPT ); Sat, 26 Nov 2016 08:23:55 -0500 Received: from Galois.linutronix.de ([146.0.238.70]:42804 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750745AbcKZNXz (ORCPT ); Sat, 26 Nov 2016 08:23:55 -0500 Date: Sat, 26 Nov 2016 14:20:59 +0100 (CET) From: Thomas Gleixner To: Pavel Machek cc: Grzegorz Andrejczuk , mingo@redhat.com, hpa@zytor.com, x86@kernel.org, bp@suse.de, dave.hansen@linux.intel.com, lukasz.daniluk@intel.com, james.h.cownie@intel.com, jacob.jun.pan@intel.com, Piotr.Luc@intel.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6: 2/4] x86: Add enabling of the R3MWAIT during boot In-Reply-To: <20161126131542.GB20568@xo-6d-61-c0.localdomain> Message-ID: References: <1477576923-3244-1-git-send-email-grzegorz.andrejczuk@intel.com> <1477576923-3244-3-git-send-email-grzegorz.andrejczuk@intel.com> <20161126131542.GB20568@xo-6d-61-c0.localdomain> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 658 Lines: 18 On Sat, 26 Nov 2016, Pavel Machek wrote: > On Thu 2016-10-27 16:38:13, Thomas Gleixner wrote: > > On Thu, 27 Oct 2016, Grzegorz Andrejczuk wrote: > > > +#ifdef CONFIG_X86_64 > > > +static int phi_r3mwait_disabled __read_mostly; > > > + > > > +static int __init phir3mwait_disable(char *__unused) > > > +{ > > > + phi_r3mwait_disabled = 1; > > > + pr_warn("x86/phir3mwait: Disabled ring 3 MWAIT for Xeon Phi"); > > > > Why would that be a warning? The sysadmin added the command line switch, so > > why does he needs to be warned? > > Its telling admin he did not make a typo on the command line. We often do that.... Definitely not at the warning level.