Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751710AbcKZNqj (ORCPT ); Sat, 26 Nov 2016 08:46:39 -0500 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:48315 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751099AbcKZNqg (ORCPT ); Sat, 26 Nov 2016 08:46:36 -0500 Date: Sat, 26 Nov 2016 08:46:38 -0500 From: Chris Mason To: Christian Borntraeger CC: linux-btrfs , Linux Kernel Mailing List Subject: Re: btrfs: still lockdep splat for 4.9-rc5+ (btrfs_log_inode) Message-ID: <20161126134638.GA79987@clm-mbp.masoncoding.com> Mail-Followup-To: Chris Mason , Christian Borntraeger , linux-btrfs , Linux Kernel Mailing List References: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; format=flowed Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-Originating-IP: [172.101.197.43] X-ClientProxiedBy: CY1PR05CA0031.namprd05.prod.outlook.com (10.166.186.169) To DM5PR15MB1243.namprd15.prod.outlook.com (10.173.209.137) X-Microsoft-Exchange-Diagnostics: 1;DM5PR15MB1243;2:PQqty9w/rhDOvggqOKXVrtBP96TLiHlzap9CACYFUBN5Pvm9u2vpkLkmoFrqILFUCz/26UJ38KSAiFbDtNPWM5lH6KdQMYWB8PWO5BRXkidAwfc2yYSwsCv42v1Gs8FN5H/Y+PtIt81xvp+/nwKWt8/vTJ2ePvXX24zvF377GeY=;3:Qd1zaiwqy1OB6hZXyg4wWmZ41nJxegknaCkps4kSO2PQwe/PI/sYX7XAmN/+V7HTO0Q8zJG/sAMlEy7tb7nS9WKKny5b0aNnauXwWQV/eawPK1wga7oVtMOR+QQHNN4bU7eRDeDOVglNZ59SoXe24rz75cBFgZohoGvNepyzing= X-MS-Office365-Filtering-Correlation-Id: adfe79c8-cb2a-46e7-e1d4-08d4160296a7 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:DM5PR15MB1243; X-Microsoft-Exchange-Diagnostics: 1;DM5PR15MB1243;25:cuOk2if7sJTGOO5nbA/E8hAFbVKBA0vybnynDGf0khaTKEH1y34H7ACppjaZwEPmtwYP+GUek9X7ti6CGE1qcsjk+dX0BeopO4euCUJ18Y5y1/pCwEEaeLVd/n5kifXbGKP2DRQYlsF3Znq/lDQCKsyC/5QPalw0Q2r/h93s1LbTx7hozGhDAminwG8QS+/dcDmCXQIKGpMfbk4dTEUlOll5bXg9s8KYMLKGbb8A5pdiOD61g8y5lorN/oZjPPaATEYqXGV1u0vSbOyBe3m9CSioJEeu6b9jbz5jOYVjoNq30PHLxdi2H4CYfa2y0+sU9PFQMSaMQ9RmLjdMZd+V6aLFqDXUcP2EFXcErC/1GGHNJ4Nm2wjipWUHmn5X/+ZVr7grx6XAN107sEtXitfBzLADIXet1YaqcqqQkqiG37WqGV/NJdDkEo8kBSOAb5M1mW1+4CPzKnZ6KMSqK2WwkDzJlxxV/+MxmeODzoKWHZWMh8oEduikd212l21DiJ1G5Ck7FxpRCz/m/KF6pydukhjLKHMLSgKAttn8djoKxWUcM8vD9izjFnP7UaJNZ6wMPZXWnBqTk8nGfsTlVgLFII7R4GCkiirm8OKTXahbCkCf/7SHGVUqOPFwblkOLndwWh4c2e99ZbJgwL3wtf0SBb64nH5+b1btCQ2NEBGTw7mVfzJZi3iaM/RHSzb4TMBD8jEIBwOeh+eDuZP4Z25YDVLkVs7I1NCaShj+YbAf74+TwGQMJsTwyCBypQbDMgK3 X-Microsoft-Exchange-Diagnostics: 1;DM5PR15MB1243;31:DxkdPhkgXX3W0VyhuiBgyUpX77X/pXIiT+NpVgK1N/tZ3rRRL3i1k4qw/3ga2ycw496qFcXX9YbotMAnBgkamG43JGekgqpLXZbMUbuHXgO/LBYPWM+4wq6OR/xFp/mjYPLBIqugaW/ginKhpruUAAIQRf0Q7ZhILEotwQ2qY0s2fU8EmAGIRwnmdJLr6UpEjIGFsN+F0Lgcdw2ZzQVBzd1uw1ZynLtVQBQULuSpFTjrXKNykrSRUK2crkWwetr9lGdkWFXBOs63zMtS5kFb7OlL2ciTHXFOwPt2ZNPzYYU=;20:Uee65RjrgoFg73lx5H8o1pJDTHDWfCdd4z/cTW1U7RI1u8t5Y1IYR/e8TZVwV7GJlyiRfrSh6gYC9fubltal1FS7MLOMKmcFPUcrd+LV60WPpElnJ7gYrDiJmLqEcKWOf38jOHH2YS3AGCu6UF/2IowHCIdRoWdt6sqaxTlFLTvup4GPc81VQwOR8z3yQvaFLMluCda3Cbwqm7WzGdc14AAgw48jdmcr1OCjoi0/czcfDod+qMVAVifq734/cF+C X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6045199)(6060326)(6040361)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6041248)(6061324)(20161123555025)(20161123564025)(20161123560025)(20161123562025);SRVR:DM5PR15MB1243;BCL:0;PCL:0;RULEID:;SRVR:DM5PR15MB1243; X-Microsoft-Exchange-Diagnostics: 1;DM5PR15MB1243;4:Khq4f+Tl5GjTWMJr07J/RsL799XaBar1GoA+QmXLd7I4rsFpRwYrryuhfdKYUL5Op2j5lf1ia9ah3VA1oAyl9tUZRv1RgUjvwwl9l4+OoDWUPPYIMBHqR5gylvBIWEpveowOX/eljhwz6x+ZbM1YYw0Xv0+vnmpJVPOTvvvteMsxDgL2iO5WGkjxBvMfsUcXEs3Lyk4Cp+QLMQ52ft+eF5MSmHdVjJaX9C3vvox3zYhJ/5x5K9UFpguCoX87OoKgEB/U6SoZ8Q9z1zrCf9Eb+z6Fnh6EWId6HlEw5PxHFUiHgWQmqrOx5ure3HyAvK1Rg0/ZYwbd8OY8trfJlsY8X411PPlNyyiK3EMh71nnsC9RY4KECJpn1vrUSW01v5usECawZL2Vg1zLkvWOV0IyyHJK0rMyEIKygshZvk0Z8XyQzN5jc05+K3Bg1YYcXdL6DpAOw71W7j5A76UWACk0dnldJEsTx9HZJ4SVpUlJGk5T8luS/I54QesTfeahO1YhDLjwUhv/zCt+R7EBdJeOk+9ozHbbtRLmlYkkKPQMT3WBt01h/oa4tPaGU9uu8NMpg0vvr7D/aRUmqv1KLvLLQLV0R5tqULveUV4psF3EMXs= X-Forefront-PRVS: 0138CD935C X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(7916002)(24454002)(189002)(199003)(3846002)(97736004)(39450400002)(92566002)(733004)(7846002)(305945005)(53416004)(7736002)(76176999)(189998001)(4001350100001)(6116002)(69596002)(83506001)(54356999)(39400400001)(2906002)(8676002)(39380400001)(38730400001)(50986999)(4326007)(23726003)(1076002)(86362001)(105586002)(66066001)(106356001)(2950100002)(5660300001)(110136003)(50466002)(6916009)(33656002)(81166006)(81156014)(101416001)(68736007)(9686002)(6666003)(558084003)(47776003)(229853002)(39410400001)(42186005)(18370500001)(42262002);DIR:OUT;SFP:1102;SCL:1;SRVR:DM5PR15MB1243;H:clm-mbp.masoncoding.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;DM5PR15MB1243;23:EetAj+Hh4sZVHsj3YbasQR34VFFKuTu/z0Yc7Bf1x?= =?us-ascii?Q?+mL+md5RTW5ubyjZlg02lXQ9uXEbuutiYKl+X4sSQ/QAgn4S836ixfDmT6ZX?= =?us-ascii?Q?+8Kek3NRPnWkrLcK05+/9jQ+UhXZB7Nq25P9v4lNsZmQ/Urp/Px4ZKF6Cr/U?= =?us-ascii?Q?gAsgba8+ZwObRBvD0Ck/lcLPw/g/+BB4CzjPfk9eUCVwsf7xcLSoq/eL2h3p?= =?us-ascii?Q?INB6Qe2tfYuX7hdKf3FWOUkGRRIuOwPuZAaHqdEZ4Zn8iiVKZE6Ad6CPX7fc?= =?us-ascii?Q?DHW8JwRepVGdMKbavzakPbNHhgBWge0rAKnSAHis78YQCtz+F88g9WSkz1Ns?= =?us-ascii?Q?mPJuDolhspaFnvUufgq1qi5YXeh5bFBi5Pn39nUpRv391qlVXzr5ni3452mu?= =?us-ascii?Q?i2rEBC8dcBx/odEmNgJ82l96bEJa3bicDiNlxRBxoDLQ8d2Wn5S8m9JNbM+p?= =?us-ascii?Q?FyXkFNuW4EZvv8yC4+Ef7uNdZ9WGGWdxEXg3qtL5DGDhlHV8AZraPTYtfrKb?= =?us-ascii?Q?Lam8yO0Qwer9UOsEuAa8JWZW4S3TdIJ8nzpQcNpjgnLNaUzEBCfXOn/ewF/T?= =?us-ascii?Q?Rbj2cvOJSHOTFsKPT9xdtx2n9fobyidh5uahXLV/dbmSQJt5Ga0iYzW4D+cV?= =?us-ascii?Q?3dcserC71dVTDifVWr7s/N/N+r4o+JIR+3qvKHGigndO8jUyJbpSBxSDqBjR?= =?us-ascii?Q?3Tko+oFuWvtvu5ck4Jt7D73QGTuCt1lyx69RykHeF24GpZC6aS+Q3027X1v0?= =?us-ascii?Q?Y6lxjsvguygfHPf9MIdG6JQEAu+NlFR8y5Buv+MrX2dxjxsT40jzA0UuiQ+O?= =?us-ascii?Q?3Io+GE3r5lX56RFRlGynHPEknhmDMpR24awzk/vXaO2lRkx/KU3iSxhluCRV?= =?us-ascii?Q?CiJqAKEF3Ufh8EwJy1RrqKs/7XrAZTYIwlUqiugroV+r6YADY7eSkeo0GoYo?= =?us-ascii?Q?UxVmIL2kYG4NZWeIeuFqSr/3L469xoOXeVPcX135ytFd6RnCVRwBH/MWsrMQ?= =?us-ascii?Q?RCIq9+QXn5gcKluTbs7bt2dD6k1koYOedV+4UiQXhrWhUcNapq5aYoF63SEB?= =?us-ascii?Q?sp6rEcI1ixGA6Lebb5yZMoOcJX9kLbL5EWk/G6J0gkNqVkL4S8H5IPYfATUq?= =?us-ascii?Q?L22sHraxY/DUHtf6xYqyw+JecQVaxT+lICqfba43JkozvvxHMWEjB79bH7c+?= =?us-ascii?Q?gMRNWuBsdLW2cCBs1K3CRO+OiZluiQqqrHcISVqluB/RXXg7DBD+Lf0xd3Qz?= =?us-ascii?Q?/IZMz6YgWOWGlM5vVzAT8jLUhgaM1BFTbAej59W4gU6Dy0n8LyEfbEtnPt9t?= =?us-ascii?Q?Jx7gvhmxKqYky9y6b5NXSLNOn9jm/2OK2yWPTtQJOsBtqUwG9e/rg8LsVtnF?= =?us-ascii?Q?n9N8A=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;DM5PR15MB1243;6:jxfHGUHfYJLB7xYrf4+ZOqVNLMxOXvqsn3jdFMRx1gQyo0BI2IohktrYKVnEAvuVBOqCtULFF/0gwgSN5pCmtkjUKhIr2T3oH4qI+FaHGUGXhlowCvB+UBn2Le1VsAjffehd7Fg6mIh9FY+9CtDNkVZxvuNZkanUqJz5vBXb1+DM0gVr7ye3k2BPkgHUixPgM+CFvgPRuPJnpNaFz5vsNQvm2kPFZJqZ75qJSpq0AYZB8xB+Z6iuHaNmgeHOKs89cneShVHJgqxYCGbIHviO9zRPxtrsF7XEMGNOmInY+TLlk5xHH8HqR5WqA1R27/+UCKJLHmP6T1XwHR1TuKTGgJAKVco/tJ1rqHsYbs0L8p0=;5:QDqx91BJn/GJzKc8FjgfhAezDZWwUD6idqXZ0vlbDnVQQ/lsBuNVqAkw9VlHNQuC3swnlDZOfg6rN5VrCVdKxPfVl2UW11vYjngY+iB40O42NkLm4xyOq3HwIk5u48vnLq5NiwWXY9bXmmzEOlapew==;24:saH7KUM41mLX614PLH7kiEsQTZSrCOskmQluznOwFlKIPIEplv0a5cmKXpV0IBQAYWtdkwhdOrOfLLw0GEzBDC24W7u6u2ccRtwy3s0X3Cc= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DM5PR15MB1243;7:s8Y4COc0cBdPhPa9azhzFc2Cxu3rUtjOanK62b5M4DMzuildgwm1WaXHvpSnCbDzL9HcjjGfxLYdBhTfFrKyEVeDkRewe3J8aGY4/9i6UjmJVWHTI/5D6YPWcjh1LdIgcfebOq5oZA0PzzWOJi3b+0jm5tGUtPjvhbFXmKs80+ncTO5Hl+E1uKbo7x1cQ3ttiBwHaUMADwLWon8Nd9P5YhFBq+MxyLikjKRoXewni3U9nuSorhKlqHPfH9oWaDIZIZEeL5SeoXMHTeq2RU6D0NvCVrvcLEyp9hKd5VakGNtaaNhbq/+zk5mVPesa5W7hZ2kludQyZwVCaasl4S1g7VI3qc+k0a72eYoIMZX0LLE=;20:d6V4ivn2SriSJ0pWBuJwQfQ+l/GwG2NegYiNR3RvXKzNpPkqzphmrSvQYhZ7qGv5YlfitHkGjPUB8tYDtv4k8ggBhGY2icjSdxbqqTVc0zpnws0aesKA8KiuDizQhsQDPtF8Squ7bXmjfYfWg7lyzJ1TXglGI+J16UtigylAIYE= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Nov 2016 13:46:13.4568 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR15MB1243 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-11-26_09:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 257 Lines: 7 On Fri, Nov 25, 2016 at 10:03:25AM +0100, Christian Borntraeger wrote: >FWIW, I still see the lockdep splat in btrfs in 4.9-rc5+ Filipe reworked the code to avoid taking the same lock twice. As far as I can tell, this just needs some annotation. -chris