Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751792AbcKZNwQ (ORCPT ); Sat, 26 Nov 2016 08:52:16 -0500 Received: from mail-lf0-f46.google.com ([209.85.215.46]:36288 "EHLO mail-lf0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751192AbcKZNwJ (ORCPT ); Sat, 26 Nov 2016 08:52:09 -0500 MIME-Version: 1.0 In-Reply-To: <20161126100229.GO6266@mwanda> References: <20161121221702.6438-1-christophe.jaillet@wanadoo.fr> <20161125215139.GM6266@mwanda> <20161126100229.GO6266@mwanda> From: Mike Marshall Date: Sat, 26 Nov 2016 08:51:57 -0500 Message-ID: Subject: Re: [PATCH] orangefs: Axe some dead code To: Dan Carpenter Cc: Martin Brandenburg , Christophe JAILLET , LKML , kernel-janitors@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1230 Lines: 31 I think I understand what you're saying, except for this part: > would have been secretly disapointed at your lack of > courage in my heart but it would have been normal and fine. I'm pretty sure that Linus won't accept a pull request from me at the wrong time and that I won't send one at the wrong time on purpose. I've been laboring under the belief that the rc period is when we "push only patches that do not include new functionalities", and I would have thought that stripping out a few lines of dead code would be appropriate then. -Mike On Sat, Nov 26, 2016 at 5:02 AM, Dan Carpenter wrote: > On Fri, Nov 25, 2016 at 06:09:39PM -0500, Mike Marshall wrote: >> We're on rc7 now. Linus said in LWN that there might be a rc8 this time. >> I'll try to get this pulled in 4.9-rc8 I hope, or sometime in 4.10... >> it is just a >> few lines of code that I don't think can be reached. Sorry for the confusion. > > It's not -rc material at all. Especially not after -rc2. If you had > said 4.11, I would have been secretly disapointed at your lack of > courage in my heart but it would have been normal and fine. Merging > this in 4.10 is the earliest reasonable. > > regards, > dan carpenter >