Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753311AbcKZSIj (ORCPT ); Sat, 26 Nov 2016 13:08:39 -0500 Received: from conuserg-11.nifty.com ([210.131.2.78]:47890 "EHLO conuserg-11.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753109AbcKZSIK (ORCPT ); Sat, 26 Nov 2016 13:08:10 -0500 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-11.nifty.com uAQI6Ueh018512 X-Nifty-SrcIP: [111.169.71.157] From: Masahiro Yamada To: linux-mtd@lists.infradead.org Cc: Masahiro Yamada , linux-kernel@vger.kernel.org, Boris Brezillon , Marek Vasut , Brian Norris , Richard Weinberger , David Woodhouse , Cyrille Pitchen Subject: [PATCH 11/39] mtd: nand: denali: increment ecc_stats.failed by one per error Date: Sun, 27 Nov 2016 03:05:57 +0900 Message-Id: <1480183585-592-12-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1480183585-592-1-git-send-email-yamada.masahiro@socionext.com> References: <1480183585-592-1-git-send-email-yamada.masahiro@socionext.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1057 Lines: 29 If the addressed page is not erased, the two calls of is_erase() will both return false, then mtd->ecc_stats.failed will be incremented by two. Rather, increment it by one because the whole page including OOB area is transferred in one transaction. Signed-off-by: Masahiro Yamada --- drivers/mtd/nand/denali.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/mtd/nand/denali.c b/drivers/mtd/nand/denali.c index ab59371..ae9a8d2 100644 --- a/drivers/mtd/nand/denali.c +++ b/drivers/mtd/nand/denali.c @@ -1157,9 +1157,8 @@ static int denali_read_page(struct mtd_info *mtd, struct nand_chip *chip, read_oob_data(mtd, chip->oob_poi, denali->page); /* check ECC failures that may have occurred on erased pages */ - if (!is_erased(buf, mtd->writesize)) - mtd->ecc_stats.failed++; - if (!is_erased(chip->oob_poi, mtd->oobsize)) + if (!is_erased(buf, mtd->writesize) || + !is_erased(chip->oob_poi, mtd->oobsize)) mtd->ecc_stats.failed++; } return max_bitflips; -- 2.7.4