Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753511AbcK0H5v (ORCPT ); Sun, 27 Nov 2016 02:57:51 -0500 Received: from server.coly.li ([162.144.45.48]:58336 "EHLO server.coly.li" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751671AbcK0H5s (ORCPT ); Sun, 27 Nov 2016 02:57:48 -0500 Subject: Re: [PATCH 1/2] bcache: Remove redundant set_capacity To: Yijing Wang , axboe@fb.com, kent.overstreet@gmail.com References: <1480037969-45042-1-git-send-email-wangyijing@huawei.com> Cc: git@linux.ewheeler.net, colyli@suse.de, linux-bcache@vger.kernel.org, linux-kernel@vger.kernel.org From: Coly Li Message-ID: <749db728-10d0-ab33-4587-9b6b0e98725e@coly.li> Date: Sun, 27 Nov 2016 15:57:38 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:45.0) Gecko/20100101 Thunderbird/45.5.0 MIME-Version: 1.0 In-Reply-To: <1480037969-45042-1-git-send-email-wangyijing@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - server.coly.li X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - coly.li X-Get-Message-Sender-Via: server.coly.li: authenticated_id: i@coly.li X-Authenticated-Sender: server.coly.li: i@coly.li X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 912 Lines: 33 On 2016/11/25 上午9:39, Yijing Wang wrote: > set_capacity() has been called in bcache_device_init(), > remove the redundant one. > > Signed-off-by: Yijing Wang > --- > drivers/md/bcache/super.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c > index 849ad44..b638a16 100644 > --- a/drivers/md/bcache/super.c > +++ b/drivers/md/bcache/super.c > @@ -1126,9 +1126,6 @@ static int cached_dev_init(struct cached_dev *dc, unsigned block_size) > if (ret) > return ret; > > - set_capacity(dc->disk.disk, > - dc->bdev->bd_part->nr_sects - dc->sb.data_offset); > - > dc->disk.disk->queue->backing_dev_info.ra_pages = > max(dc->disk.disk->queue->backing_dev_info.ra_pages, > q->backing_dev_info.ra_pages); > Hi Yijing, Nice catch, it looks good to me. Acked-by: Coly Li -- Coly Li