Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753571AbcK0IBL (ORCPT ); Sun, 27 Nov 2016 03:01:11 -0500 Received: from server.coly.li ([162.144.45.48]:58348 "EHLO server.coly.li" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751671AbcK0IBB (ORCPT ); Sun, 27 Nov 2016 03:01:01 -0500 Subject: Re: [PATCH 2/2] bcache: remove unused parameter To: Yijing Wang , axboe@fb.com, kent.overstreet@gmail.com References: <1480038004-45129-1-git-send-email-wangyijing@huawei.com> Cc: git@linux.ewheeler.net, colyli@suse.de, linux-bcache@vger.kernel.org, linux-kernel@vger.kernel.org From: Coly Li Message-ID: Date: Sun, 27 Nov 2016 16:00:47 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:45.0) Gecko/20100101 Thunderbird/45.5.0 MIME-Version: 1.0 In-Reply-To: <1480038004-45129-1-git-send-email-wangyijing@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - server.coly.li X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - coly.li X-Get-Message-Sender-Via: server.coly.li: authenticated_id: i@coly.li X-Authenticated-Sender: server.coly.li: i@coly.li X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2340 Lines: 69 On 2016/11/25 上午9:40, Yijing Wang wrote: > Parameter bio is no longer used, clean it. > > Signed-off-by: Yijing Wang > --- > drivers/md/bcache/request.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/md/bcache/request.c b/drivers/md/bcache/request.c > index 40ffe5e..bf6e432 100644 > --- a/drivers/md/bcache/request.c > +++ b/drivers/md/bcache/request.c > @@ -26,12 +26,12 @@ struct kmem_cache *bch_search_cache; > > static void bch_data_insert_start(struct closure *); > > -static unsigned cache_mode(struct cached_dev *dc, struct bio *bio) > +static unsigned cache_mode(struct cached_dev *dc) > { > return BDEV_CACHE_MODE(&dc->sb); > } > > -static bool verify(struct cached_dev *dc, struct bio *bio) > +static bool verify(struct cached_dev *dc) > { > return dc->verify; > } > @@ -371,7 +371,7 @@ static struct hlist_head *iohash(struct cached_dev *dc, uint64_t k) > static bool check_should_bypass(struct cached_dev *dc, struct bio *bio) > { > struct cache_set *c = dc->disk.c; > - unsigned mode = cache_mode(dc, bio); > + unsigned mode = cache_mode(dc); > unsigned sectors, congested = bch_get_congested(c); > struct task_struct *task = current; > struct io *i; > @@ -746,7 +746,7 @@ static void cached_dev_read_done(struct closure *cl) > s->cache_miss = NULL; > } > > - if (verify(dc, &s->bio.bio) && s->recoverable && !s->read_dirty_data) > + if (verify(dc) && s->recoverable && !s->read_dirty_data) > bch_data_verify(dc, s->orig_bio); > > bio_complete(s); > @@ -771,7 +771,7 @@ static void cached_dev_read_done_bh(struct closure *cl) > > if (s->iop.error) > continue_at_nobarrier(cl, cached_dev_read_error, bcache_wq); > - else if (s->iop.bio || verify(dc, &s->bio.bio)) > + else if (s->iop.bio || verify(dc)) > continue_at_nobarrier(cl, cached_dev_read_done, bcache_wq); > else > continue_at_nobarrier(cl, cached_dev_bio_complete, NULL); > @@ -898,7 +898,7 @@ static void cached_dev_write(struct cached_dev *dc, struct search *s) > s->iop.bypass = true; > > if (should_writeback(dc, s->orig_bio, > - cache_mode(dc, bio), > + cache_mode(dc), > s->iop.bypass)) { > s->iop.bypass = false; > s->iop.writeback = true; > Acked-by: Coly Li -- Coly Li