Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752466AbcK0PNG (ORCPT ); Sun, 27 Nov 2016 10:13:06 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:37956 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751872AbcK0PND (ORCPT ); Sun, 27 Nov 2016 10:13:03 -0500 Date: Sun, 27 Nov 2016 16:12:38 +0100 From: Boris Brezillon To: Masahiro Yamada Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Marek Vasut , Brian Norris , Richard Weinberger , David Woodhouse , Cyrille Pitchen Subject: Re: [PATCH 04/39] mtd: nand: denali: remove more unused struct members Message-ID: <20161127161238.750ca39a@bbrezillon> In-Reply-To: <1480183585-592-5-git-send-email-yamada.masahiro@socionext.com> References: <1480183585-592-1-git-send-email-yamada.masahiro@socionext.com> <1480183585-592-5-git-send-email-yamada.masahiro@socionext.com> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1544 Lines: 42 On Sun, 27 Nov 2016 03:05:50 +0900 Masahiro Yamada wrote: Please add a description here. Also, this commit tends to validate my fears: you should have wait for the full rework/cleanup to be done before submitting the first round of cleanups. Indeed, commit c4ae0977f57d ("mtd: nand: denali: remove unused struct member denali_nand_info::idx") was removing one of these unused fields, leaving 2 of them behind. While I like when things I clearly separated in different commits, when you push the logic too far, you end up with big series which are not necessarily easier to review, and several commits that are achieving the same goal... > Signed-off-by: Masahiro Yamada > --- > > drivers/mtd/nand/denali.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/mtd/nand/denali.h b/drivers/mtd/nand/denali.h > index fd1ae08..4fad43b 100644 > --- a/drivers/mtd/nand/denali.h > +++ b/drivers/mtd/nand/denali.h > @@ -407,7 +407,6 @@ struct denali_nand_info { > struct nand_buf buf; > struct device *dev; > int total_used_banks; > - uint32_t block; /* stored for future use */ > uint16_t page; > void __iomem *flash_reg; /* Mapped io reg base address */ > void __iomem *flash_mem; /* Mapped io reg base address */ > @@ -416,7 +415,6 @@ struct denali_nand_info { > struct completion complete; > spinlock_t irq_lock; > uint32_t irq_status; > - int irq_debug_array[32]; > int irq; > > uint32_t devnum; /* represent how many nands connected */