Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753152AbcK0Sg5 (ORCPT ); Sun, 27 Nov 2016 13:36:57 -0500 Received: from mga04.intel.com ([192.55.52.120]:7460 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752187AbcK0Sgr (ORCPT ); Sun, 27 Nov 2016 13:36:47 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,707,1473145200"; d="scan'208";a="791374229" From: Jani Nikula To: "S. Fricke" , Peter Zijlstra Cc: linux-doc@vger.kernel.org, Jonathan Corbet , Ming Lei , "Luis R . Rodriguez" , Mauro Carvalho Chehab , linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/4] Documentation/atomic_ops.txt: convert to ReST markup In-Reply-To: <20161127145334.GH14150@sfserver> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20161125215814.GA3061@worktop.programming.kicks-ass.net> <20161127145334.GH14150@sfserver> Date: Sun, 27 Nov 2016 20:36:32 +0200 Message-ID: <87polgrcr3.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1386 Lines: 38 On Sun, 27 Nov 2016, "S. Fricke" wrote: > Hi Peter, > >> On Fri, Nov 25, 2016 at 03:59:45PM +0100, Silvio Fricke wrote: >> > ... and move to core-api folder. >> > >> > Signed-off-by: Silvio Fricke >> > --- >> > Documentation/atomic_ops.txt => Documentation/core-api/atomic_ops.rst | 777 +++++++++++++++++++++++++++++++++++++----------------------------------- >> > Documentation/core-api/index.rst | 1 +- >> > Documentation/process/volatile-considered-harmful.rst | 3 +- >> > 3 files changed, 404 insertions(+), 377 deletions(-) >> >> Not a fan of this. The atomic_ops.txt file needs a lot of love, and I >> wouldn't want to edit a .rst file. > > What is the problem with this rst-file? atomic_ops.rst are not so > different to the txt variant. There is nothing particularly wrong with the patch. Perhaps you could leave the tabs in place instead of indenting with spaces in the code blocks. It would result in a smaller diff. But other than that, it's fine. I'm sure Peter is capable of editing a file with a .rst extension, and we can clean up any hickups afterwards if getting the formatting right is insurmountable. > I will drop this patch. Please don't. Please let Jon be the judge of that. Thanks, Jani. -- Jani Nikula, Intel Open Source Technology Center