MIME-Version: 1.0
In-Reply-To: <20161120175207.GA4354@localhost>
References: <20161120175207.GA4354@localhost>
From: Andy Lutomirski <luto@amacapital.net>
Date: Sun, 27 Nov 2016 10:57:31 -0800
Message-ID: <CALCETrVeWs7DvM0TDTb+0-Twk=n7Pvf7XEVrHS0kKXvX-v0n8g@mail.gmail.com>
Subject: Re: Question: goal of twice disabling of preemption in exception handlers
To: Alexnader Kuleshov <kuleshovmail@gmail.com>
Cc: open list <linux-kernel@vger.kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
        Borislav Petkov <bp@alien8.de>, Andy Lutomirski <luto@kernel.org>,
        Paul Gortmaker <paul.gortmaker@windriver.com>,
        Jan Beulich <jbeulich@suse.com>, Tony Luck <tony.luck@intel.com>,
        Jianyu Zhan <nasa4836@gmail.com>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 901
Lines: 18

On Sun, Nov 20, 2016 at 9:52 AM, Alexnader Kuleshov
<kuleshovmail@gmail.com> wrote:
> Hello everyone,
>
> Exception handlers which may run on IST stack disable and enable preemption
> twice. For example do_int3() [1]. This one calls ist_enter() which
> disables preemption with preempt_disable() every time without any conditions.
> And later do_int3() calls preempt_disable() again [2] before do_trap().
>
> Of course we decrement preemption counter in the end of such exception
> handlers twice too. But what's actual purpose of doing this two times?
>
> [1] https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/tree/arch/x86/kernel/traps.c?id=refs/tags/next-20161117#n530
> [2] https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/tree/arch/x86/kernel/traps.c?id=refs/tags/next-20161117#n566
>
> Thank you.

You could submit a patch to get rid of the extra one if you like.