Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753788AbcK1AJI (ORCPT ); Sun, 27 Nov 2016 19:09:08 -0500 Received: from ozlabs.org ([103.22.144.67]:33317 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751154AbcK1AJA (ORCPT ); Sun, 27 Nov 2016 19:09:00 -0500 From: Rusty Russell To: Jessica Yu , AKASHI Takahiro Cc: mark.rutland@arm.com, keescook@chromium.org, kernel-hardening@lists.openwall.com, linux-kernel@vger.kernel.org Subject: Re: module: extend 'rodata=off' boot cmdline parameter to module mappings In-Reply-To: <20161125054822.GA2793@packer-debian-8-amd64.digitalocean.com> References: <20161114061505.15238-1-takahiro.akashi@linaro.org> <20161125054822.GA2793@packer-debian-8-amd64.digitalocean.com> User-Agent: Notmuch/0.22.1 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Mon, 28 Nov 2016 10:30:53 +1030 Message-ID: <8760n88ocq.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1056 Lines: 27 Jessica Yu writes: > +++ AKASHI Takahiro [14/11/16 15:15 +0900]: >>The current "rodata=off" parameter disables read-only kernel mappings >>under CONFIG_DEBUG_RODATA: >> commit d2aa1acad22f ("mm/init: Add 'rodata=off' boot cmdline parameter >> to disable read-only kernel mappings") >> >>This patch is a logical extension to module mappings ie. read-only mappings >>at module loading can be disabled even if CONFIG_DEBUG_SET_MODULE_RONX >>(mainly for debug use). Please note, however, that it only affects RO/RW >>permissions, keeping NX set. >> >>This is the first step to make CONFIG_DEBUG_SET_MODULE_RONX mandatory >>(always-on) in the future as CONFIG_DEBUG_RODATA on x86 and arm64. >> >>Suggested-by: and Acked-by: Mark Rutland >>Signed-off-by: AKASHI Takahiro >>Reviewed-by: Kees Cook >>Cc: Rusty Russell > > Hi Rusty, could I get an (n)ack for this patch? :-) Acked-by: Rusty Russell Cheers, Rusty.