Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752924AbcK1Awt (ORCPT ); Sun, 27 Nov 2016 19:52:49 -0500 Received: from szxga04-in.huawei.com ([119.145.14.52]:40483 "EHLO szxga04-in.huawei.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751033AbcK1Awk (ORCPT ); Sun, 27 Nov 2016 19:52:40 -0500 Subject: Re: [PATCH 1/2] bcache: Remove redundant set_capacity To: Coly Li , , References: <1480037969-45042-1-git-send-email-wangyijing@huawei.com> <749db728-10d0-ab33-4587-9b6b0e98725e@coly.li> CC: , , , From: wangyijing Message-ID: <583B7F9D.3050208@huawei.com> Date: Mon, 28 Nov 2016 08:51:41 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <749db728-10d0-ab33-4587-9b6b0e98725e@coly.li> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.177.23.4] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 986 Lines: 37 在 2016/11/27 15:57, Coly Li 写道: > On 2016/11/25 上午9:39, Yijing Wang wrote: >> set_capacity() has been called in bcache_device_init(), >> remove the redundant one. >> >> Signed-off-by: Yijing Wang >> --- >> drivers/md/bcache/super.c | 3 --- >> 1 file changed, 3 deletions(-) >> >> diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c >> index 849ad44..b638a16 100644 >> --- a/drivers/md/bcache/super.c >> +++ b/drivers/md/bcache/super.c >> @@ -1126,9 +1126,6 @@ static int cached_dev_init(struct cached_dev *dc, unsigned block_size) >> if (ret) >> return ret; >> >> - set_capacity(dc->disk.disk, >> - dc->bdev->bd_part->nr_sects - dc->sb.data_offset); >> - >> dc->disk.disk->queue->backing_dev_info.ra_pages = >> max(dc->disk.disk->queue->backing_dev_info.ra_pages, >> q->backing_dev_info.ra_pages); >> > > Hi Yijing, > > Nice catch, it looks good to me. > > Acked-by: Coly Li Thanks! >