Message-ID: <87oa10wgym.wl%kuninori.morimoto.gx@renesas.com>
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Arnd Bergmann <arnd@arndb.de>
CC: Archit Taneja <architt@codeaurora.org>,
        David Airlie <airlied@linux.ie>, Inki Dae <inki.dae@samsung.com>,
        Philipp Zabel <p.zabel@pengutronix.de>,
        Andrzej Hajda <a.hajda@samsung.com>, <dri-devel@lists.freedesktop.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drm: bridge: dw-hdmi: add ASoC dependency
In-Reply-To: <20161125205411.1157522-1-arnd@arndb.de>
References: <20161125205411.1157522-1-arnd@arndb.de>
User-Agent: Wanderlust/2.15.9 Emacs/24.3 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset="US-ASCII"
Date: Mon, 28 Nov 2016 01:07:54 +0000
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2016 01:07:54.5174 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HK2PR0601MB1442
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1245
Lines: 40


Hi

> The newly added sound driver depends on SND_SOC_HDMI_CODEC, which in
> turn only makes sense when ASoC is enabled, as shown by this warning:
> 
> warning: (DRM_MSM && DRM_STI && DRM_MEDIATEK_HDMI && DRM_I2C_NXP_TDA998X && DRM_DW_HDMI_I2S_AUDIO) selects SND_SOC_HDMI_CODEC which has unmet direct dependencies (SOUND && !M68K && !UML && SND && SND_SOC)
> 
> Since the audio driver is probably useless without the audio subsystem,
> adding a dependency here seems the right solution.
> 
> Fixes: 2761ba6c0925 ("drm: bridge: add DesignWare HDMI I2S audio support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---

Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

>  drivers/gpu/drm/bridge/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
> index 4980ecc55721..71db3e659be9 100644
> --- a/drivers/gpu/drm/bridge/Kconfig
> +++ b/drivers/gpu/drm/bridge/Kconfig
> @@ -41,6 +41,7 @@ config DRM_DW_HDMI_AHB_AUDIO
>  
>  config DRM_DW_HDMI_I2S_AUDIO
>  	tristate "Synopsis Designware I2S Audio interface"
> +	depends on SND_SOC
>  	depends on DRM_DW_HDMI
>  	select SND_SOC_HDMI_CODEC
>  	help
> -- 
> 2.9.0
> 


Best regards
---
Kuninori Morimoto