Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753978AbcK1CK5 (ORCPT ); Sun, 27 Nov 2016 21:10:57 -0500 Received: from mail-pg0-f67.google.com ([74.125.83.67]:34094 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753583AbcK1CKt (ORCPT ); Sun, 27 Nov 2016 21:10:49 -0500 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 10.1 \(3251\)) Subject: Re: [PATCH 3/3] hwmon: tmp108: Update driver to use hwmon_chip_info. From: John Muir In-Reply-To: <20161127230035.GA19132@roeck-us.net> Date: Sun, 27 Nov 2016 18:10:46 -0800 Cc: Jean Delvare , Jonathan Corbet , Mark Rutland , Rob Herring , Linux List , linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org Message-Id: References: <1480223737-82080-2-git-send-email-john@jmuir.com> <1480223737-82080-4-git-send-email-john@jmuir.com> <20161127230035.GA19132@roeck-us.net> To: Guenter Roeck X-Mailer: Apple Mail (2.3251) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id uAS2B1Vd021259 Content-Length: 789 Lines: 26 > On 2016.11.27, at 15:00 , Guenter Roeck wrote: > > On Sat, Nov 26, 2016 at 09:15:37PM -0800, John Muir wrote: >> Move the tmp108 driver from hwmon attribute groups to >> hwmon_chip_info. >> >> Signed-off-by: John Muir >> --- > > Hi John, > > please have a look at the following patch. > > Something else: Symbolic permissions are out of favor nowadays. > You might instead just use 0644 / 0444. Not that I really care, > but it prevents the inevitable follow-up patches. > Hi Guenter, Thank you for this patch. I will attempt to implement the same changes using the older interfaces in my 4.4 implementation. I will incorporate your changes and other comments as soon as I can (early this week) and re-send my patch series. Cheers, John.