Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754285AbcK1Gfm (ORCPT <rfc822;w@1wt.eu>);
        Mon, 28 Nov 2016 01:35:42 -0500
Received: from mail-sn1nam01on0113.outbound.protection.outlook.com ([104.47.32.113]:62644
        "EHLO NAM01-SN1-obe.outbound.protection.outlook.com"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1752877AbcK1Gfd (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 28 Nov 2016 01:35:33 -0500
From: Dexuan Cui <decui@microsoft.com>
To: Vitaly Kuznetsov <vkuznets@redhat.com>,
        "devel@linuxdriverproject.org" <devel@linuxdriverproject.org>
CC: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "KY Srinivasan" <kys@microsoft.com>,
        Haiyang Zhang <haiyangz@microsoft.com>,
        Stephen Hemminger <stephen@networkplumber.org>
Subject: RE: [PATCH 1/7] hv: acquire vmbus_connection.channel_mutex in
 vmbus_free_channels()
Thread-Topic: [PATCH 1/7] hv: acquire vmbus_connection.channel_mutex in
 vmbus_free_channels()
Thread-Index: AQHSRxpGlnH7W417uUGD7pdZDEeuwqDt8Gmw
Date: Mon, 28 Nov 2016 06:20:41 +0000
Message-ID: <MWHPR03MB2669D2F897EF0688B219C8A2BF8A0@MWHPR03MB2669.namprd03.prod.outlook.com>
References: <1480078123-17582-1-git-send-email-vkuznets@redhat.com>
 <1480078123-17582-2-git-send-email-vkuznets@redhat.com>
In-Reply-To: <1480078123-17582-2-git-send-email-vkuznets@redhat.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
authentication-results: spf=none (sender IP is )
 smtp.mailfrom=decui@microsoft.com; 
x-originating-ip: [2404:f801:9000:18::6bc]
x-ms-office365-filtering-correlation-id: 28881670-45ad-40ad-7c91-08d41756ad9a
x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:MWHPR03MB2493;
x-microsoft-exchange-diagnostics: 1;MWHPR03MB2493;7:4OcwM2SxmFv0svx7FlIkiyvGNqgGYhCob0GN/Hqkt5DM4yPLDEXubXJtXNLUiHEPTpI4ne9VOzh62vzM4HAUD1vhkpV7T14Bh+jxNuvkue+/9ZDNrdlwGqDBU87N1eTCmB2GIoB5jIl51VQV58d8GOn2aStPYxntXtWwEZ7XnzizBhcZzazuHAIjMr/+NaX+0doAB4VFFlon9clPSXUMsEakh+FqEKoJGk4t5PnvghonF0/FPqzAjQ1JBdO9nkBL8Gb4t1St78CHIlRqaJhJYfwRIii24wu2r7zwta4cGjU2xGZKhKS32jVKz+2I1OgyxvZpHV/Pf+VjmpWtjmzebz07NUplmguxveQIvSQMMKfy+g1BHnTrppars2LDQmZHfca5hrrC4eYbU0YkLh+1N/OBFFTOrbN34QmyyjyTCnFTjqxbLk+VHJlBjW9xSSff+n3k/xLvituNSXB9v21ZHzxQ1N7aPFEyi4HJTUUeai4=
x-microsoft-antispam-prvs: <MWHPR03MB249315D327733180DDE9B2B2BF8A0@MWHPR03MB2493.namprd03.prod.outlook.com>
x-exchange-antispam-report-test: UriScan:(9452136761055);
x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(61425038)(6060326)(6040361)(6045199)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6055026)(61426038)(61427038)(6046074)(6041248)(6061324)(20161123560025)(20161123555025)(20161123564025)(20161123562025)(6047074)(6072148);SRVR:MWHPR03MB2493;BCL:0;PCL:0;RULEID:;SRVR:MWHPR03MB2493;
x-forefront-prvs: 01401330D1
x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(7916002)(199003)(51914003)(189002)(2906002)(7696004)(86362001)(189998001)(122556002)(10090500001)(86612001)(81156014)(2950100002)(3660700001)(8936002)(81166006)(3280700002)(5660300001)(8676002)(6116002)(97736004)(101416001)(5001770100001)(2501003)(102836003)(92566002)(4326007)(10290500002)(5005710100001)(8990500004)(2900100001)(9686002)(76176999)(50986999)(54356999)(77096006)(38730400001)(305945005)(105586002)(39450400002)(7846002)(7736002)(6506003)(99286002)(106356001)(74316002)(76576001)(106116001)(33656002)(229853002)(39400400001)(39380400001)(39410400001)(68736007);DIR:OUT;SFP:1102;SCL:1;SRVR:MWHPR03MB2493;H:MWHPR03MB2669.namprd03.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en;
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
X-OriginatorOrg: microsoft.com
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Nov 2016 06:20:41.0629
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB2493
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id uAS6Zj5o017913
Content-Length: 927
Lines: 23

> From: Vitaly Kuznetsov [mailto:vkuznets@redhat.com]
> Sent: Friday, November 25, 2016 20:49
> To: devel@linuxdriverproject.org
> Cc: linux-kernel@vger.kernel.org; KY Srinivasan <kys@microsoft.com>; Haiyang
> Zhang <haiyangz@microsoft.com>; Dexuan Cui <decui@microsoft.com>;
> Stephen Hemminger <stephen@networkplumber.org>
> Subject: [PATCH 1/7] hv: acquire vmbus_connection.channel_mutex in
> vmbus_free_channels()
> 
> "kernel BUG at drivers/hv/channel_mgmt.c:350!" is observed when hv_vmbus
> module is unloaded. BUG_ON() was introduced in commit 85d9aa705184
> ("Drivers: hv: vmbus: add an API vmbus_hvsock_device_unregister()") as
> vmbus_free_channels() codepath was apparently forgotten.
> 
> Fixes: 85d9aa705184 ("Drivers: hv: vmbus: add an API
> vmbus_hvsock_device_unregister()")
> Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>

Reviewed-by: Dexuan Cui <decui@microsoft.com>

Thanks for the fix!

-- Dexuan