Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754271AbcK1Hn1 (ORCPT ); Mon, 28 Nov 2016 02:43:27 -0500 Received: from fllnx209.ext.ti.com ([198.47.19.16]:35084 "EHLO fllnx209.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750878AbcK1HnU (ORCPT ); Mon, 28 Nov 2016 02:43:20 -0500 Subject: Re: [PATCH] ARM: dts: da850: specify the maximum bandwidth for tilcdc To: Sekhar Nori , Bartosz Golaszewski , Kevin Hilman , Michael Turquette , Rob Herring , Frank Rowand , Mark Rutland , Peter Ujfalusi , Russell King References: <1480088245-8368-1-git-send-email-bgolaszewski@baylibre.com> <8829c208-0674-43c0-8449-ef764071583f@ti.com> CC: LKML , arm-soc , linux-drm , linux-devicetree , Jyri Sarha , David Airlie , Laurent Pinchart From: Tomi Valkeinen Message-ID: <953743fb-54f9-fa6f-bfdd-43d92271864f@ti.com> Date: Mon, 28 Nov 2016 09:42:30 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <8829c208-0674-43c0-8449-ef764071583f@ti.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="aFlArdT1oK6BTNeWpIsbSr2XA629M7xWp" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3784 Lines: 93 --aFlArdT1oK6BTNeWpIsbSr2XA629M7xWp Content-Type: multipart/mixed; boundary="55DF03eiPiRtXN53exhMi6ntA26p7LfrP"; protected-headers="v1" From: Tomi Valkeinen To: Sekhar Nori , Bartosz Golaszewski , Kevin Hilman , Michael Turquette , Rob Herring , Frank Rowand , Mark Rutland , Peter Ujfalusi , Russell King Cc: LKML , arm-soc , linux-drm , linux-devicetree , Jyri Sarha , David Airlie , Laurent Pinchart Message-ID: <953743fb-54f9-fa6f-bfdd-43d92271864f@ti.com> Subject: Re: [PATCH] ARM: dts: da850: specify the maximum bandwidth for tilcdc References: <1480088245-8368-1-git-send-email-bgolaszewski@baylibre.com> <8829c208-0674-43c0-8449-ef764071583f@ti.com> In-Reply-To: <8829c208-0674-43c0-8449-ef764071583f@ti.com> --55DF03eiPiRtXN53exhMi6ntA26p7LfrP Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 28/11/16 07:24, Sekhar Nori wrote: > On Friday 25 November 2016 09:07 PM, Bartosz Golaszewski wrote: >> It has been determined that the maximum resolution supported correctly= >> by tilcdc rev1 on da850 SoCs is 800x600@60. Due to memory throughput >> constraints we must filter out higher modes. >> >> Specify the max-bandwidth property for the display node for >> da850-based boards. >> >> Signed-off-by: Bartosz Golaszewski >> --- >> arch/arm/boot/dts/da850.dtsi | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dt= si >> index 8e30d9b..9b7c444 100644 >> --- a/arch/arm/boot/dts/da850.dtsi >> +++ b/arch/arm/boot/dts/da850.dtsi >> @@ -452,6 +452,7 @@ >> compatible =3D "ti,da850-tilcdc"; >> reg =3D <0x213000 0x1000>; >> interrupts =3D <52>; >> + max-bandwidth =3D <28800000>; >=20 > If this is effectively the max pixel clock that the device supports, > then why not use the datasheet specified value of 37.5 MHz (Tc =3D 26.6= 6 ns). There's a separate property for max-pixelclock. This one is maximum pixels per second (which does sound almost the same), but the doc says it's about the particular memory interface + LCDC combination. But this 'max-bandwidth' does sound quite odd, as the it really should be bytes, not pixels... Bad bindings again, which we just have to use. Tomi --55DF03eiPiRtXN53exhMi6ntA26p7LfrP-- --aFlArdT1oK6BTNeWpIsbSr2XA629M7xWp Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJYO9/mAAoJEPo9qoy8lh71+tIP/0qlxMzBHQ0HPKZct+9vg+pQ q7rMegqXHj4ngIXcrOKayt+/VYdzUJvgt7lUZZaqiW+QtS5CNA/IkQOCjPRQUBrD mjHLKMAt0MinwF4MDjbiQXKjs+g/KGEldw7LNqGD5xeHGTumKvpf/kSzDypilUed oO18vwVfKxpPSjUcQa0M36sekF3uX4+pr/19ZRg/fK3yz5c7FLcnOChJ0q7V+SHN 3RrVO6rj9Mi0FahY7yufcVskF6EWoSuDpCFiaxcHJcRXq0g8JTKcHYX+REBYl75m un3FJqu1yU6gM0u1GblD8in8drhAqdqzfr+Km3u1HgYBMoLrIBpVxaOSF3qPDTV9 Fz1DQCf1gFzoNmQvH9PR/M/WvJ2rdHj5Bbbphi8L/yYHdi9lUBUq7awXgX5O9Uxt wWo/IrbN4xbGfDtZHkGFl6xVSB1Oqh9+rXGA+7jrioBC6GmTCQtZkHlGouNdoxqO S87PN2NbTDiGKqhbXj+hkc44i30b3x2+ICiXb8UoFragZFnWZVnkt51dCW4Qks7T 4gEul6HhGkqDWqc8TbZT+9s38xd51yQbO3TRreD6yCz1VxF6hlc2swYNHzSkZaJQ fC5Q1W8esFMJ6QLEHjO40cUgJuHucv4kuQT2iIOu7fap1Jm56wMjekMTns5xYd9y 6kOPWHEu/ggHbG/dP3lW =GJrJ -----END PGP SIGNATURE----- --aFlArdT1oK6BTNeWpIsbSr2XA629M7xWp--