To: AKASHI Takahiro <takahiro.akashi@linaro.org>
Cc: Kees Cook <keescook@chromium.org>,
        Rusty Russell <rusty@rustcorp.com.au>, Jessica Yu <jeyu@redhat.com>,
        linux-kernel <linux-kernel@vger.kernel.org>
In-Reply-To: 
From: Andreas Ziegler <andreas.ziegler@fau.de>
Subject: Re: [PATCH v3] module: extend 'rodata=off' boot cmdline parameter to
 module mappings
Message-ID: <95e7fd98-c477-0c8a-7195-932e04bba9bb@fau.de>
Date: Mon, 28 Nov 2016 08:59:40 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 673
Lines: 17

Hi Akashi,

your patch "module: extend 'rodata=off' boot cmdline parameter to module
mappings" showed up in linux-next today, and I noticed a small error in it.

The first modified #ifdef is fine, the second one, however, has a spelling
mistake in it: the CONFIG_ variable should be CONFIG_DEBUG_SET_MODULE_RONX
instead of CONFIG_SET_MODULE_RONX (note the missing DEBUG).

I noticed it by running 'scripts/checkkconfigsymbols -f --force -f
next-20161124..next-20161128', which is essentialy diffing the last two
linux-next releases and looks for undefined/unknown Kconfig symbols.
You can also run the script on single commits with -c to test them.

Best regards,

Andreas