Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932235AbcK1I2d (ORCPT ); Mon, 28 Nov 2016 03:28:33 -0500 Received: from verein.lst.de ([213.95.11.211]:46843 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754060AbcK1I21 (ORCPT ); Mon, 28 Nov 2016 03:28:27 -0500 Date: Mon, 28 Nov 2016 09:28:19 +0100 From: Christoph Hellwig To: Andrzej Pietrasiewicz Cc: Laurent Pinchart , Julia Lawall , kbuild-all@01.org, Felipe Balbi , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, target-devel , Joel Becker , linux-nvme@lists.infradead.org, Christoph Hellwig , "Nicholas A. Bellinger" Subject: Re: [PATCH] usb: gadget: uvc: fix returnvar.cocci warnings Message-ID: <20161128082819.GA31105@lst.de> References: <201509170828.xv0cYNA5%fengguang.wu@intel.com> <55FAA16C.5070601@samsung.com> <2122146.rzc0RNY0pB@avalon> <3504c280-fe7f-9ec2-0f92-2b6aea290080@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3504c280-fe7f-9ec2-0f92-2b6aea290080@samsung.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 372 Lines: 7 On Wed, Nov 23, 2016 at 09:35:36AM +0100, Andrzej Pietrasiewicz wrote: > The ->drop_item() is indeed a void function, the ->drop_link() is > actually not. This, together with the fact that the value of ->drop_link() > is silently ignored suggests, that it is the ->drop_link() return > type that should be corrected and changed to void. Please send a patch to change it.