Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932271AbcK1In1 (ORCPT ); Mon, 28 Nov 2016 03:43:27 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:60188 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932111AbcK1InS (ORCPT ); Mon, 28 Nov 2016 03:43:18 -0500 DMARC-Filter: OpenDMARC Filter v1.3.1 smtp.codeaurora.org 11441612C1 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=pass smtp.mailfrom=architt@codeaurora.org Subject: Re: [PATCH] drm: bridge: dw-hdmi: add ASoC dependency To: Kuninori Morimoto , Arnd Bergmann References: <20161125205411.1157522-1-arnd@arndb.de> <87oa10wgym.wl%kuninori.morimoto.gx@renesas.com> Cc: David Airlie , Inki Dae , Philipp Zabel , Andrzej Hajda , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org From: Archit Taneja Message-ID: <29a05ff5-5479-91c1-23e5-dfaba6fb9bd3@codeaurora.org> Date: Mon, 28 Nov 2016 14:13:10 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <87oa10wgym.wl%kuninori.morimoto.gx@renesas.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1507 Lines: 56 On 11/28/2016 06:37 AM, Kuninori Morimoto wrote: > > Hi > >> The newly added sound driver depends on SND_SOC_HDMI_CODEC, which in >> turn only makes sense when ASoC is enabled, as shown by this warning: >> >> warning: (DRM_MSM && DRM_STI && DRM_MEDIATEK_HDMI && DRM_I2C_NXP_TDA998X && DRM_DW_HDMI_I2S_AUDIO) selects SND_SOC_HDMI_CODEC which has unmet direct dependencies (SOUND && !M68K && !UML && SND && SND_SOC) >> >> Since the audio driver is probably useless without the audio subsystem, >> adding a dependency here seems the right solution. >> >> Fixes: 2761ba6c0925 ("drm: bridge: add DesignWare HDMI I2S audio support") >> Signed-off-by: Arnd Bergmann >> --- > > Acked-by: Kuninori Morimoto Added to drm-misc-next Thanks for fixing this. Archit > >> drivers/gpu/drm/bridge/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig >> index 4980ecc55721..71db3e659be9 100644 >> --- a/drivers/gpu/drm/bridge/Kconfig >> +++ b/drivers/gpu/drm/bridge/Kconfig >> @@ -41,6 +41,7 @@ config DRM_DW_HDMI_AHB_AUDIO >> >> config DRM_DW_HDMI_I2S_AUDIO >> tristate "Synopsis Designware I2S Audio interface" >> + depends on SND_SOC >> depends on DRM_DW_HDMI >> select SND_SOC_HDMI_CODEC >> help >> -- >> 2.9.0 >> > > > Best regards > --- > Kuninori Morimoto > -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project