Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754573AbcK1JCw (ORCPT <rfc822;w@1wt.eu>);
        Mon, 28 Nov 2016 04:02:52 -0500
Received: from mail-pg0-f68.google.com ([74.125.83.68]:34647 "EHLO
        mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750949AbcK1JCm (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 28 Nov 2016 04:02:42 -0500
Subject: Re: [PATCH 1/6] perf config: Add support for getting config key-value
 pairs
To: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
References: <1478241862-31230-1-git-send-email-treeze.taeung@gmail.com>
 <1478241862-31230-2-git-send-email-treeze.taeung@gmail.com>
 <20161114155050.GB26543@kernel.org>
Cc: linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>, Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>, Wang Nan <wangnan0@huawei.com>,
        Nambong Ha <over3025@gmail.com>, Wookje Kwon <aweee0@gmail.com>
From: Taeung Song <treeze.taeung@gmail.com>
Message-ID: <b0479a42-2a98-cd3f-b90d-b92e49f5fc0f@gmail.com>
Date: Mon, 28 Nov 2016 18:02:36 +0900
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.2.0
MIME-Version: 1.0
In-Reply-To: <20161114155050.GB26543@kernel.org>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1160
Lines: 41

Good morning!! Arnaldo :)


On 11/15/2016 12:50 AM, Arnaldo Carvalho de Melo wrote:
> Em Fri, Nov 04, 2016 at 03:44:17PM +0900, Taeung Song escreveu:
>> Add a functionality getting specific config key-value pairs.
>> For the syntax examples,
>>
>>     perf config [<file-option>] [section.name ...]
>>
>> e.g. To query config items 'report.queue-size' and 'report.children', do
>>
>>     # perf config report.queue-size report.children
>
> So, I'm applying it, but while testing I noticed that it shows only the
> options that were explicitely set:
>
> [acme@jouet linux]$ perf config report.queue-size report.children
> report.children=false
> [acme@jouet linux]$
>
> Perhaps we should, in a follow up patch, show this instead:
>
> [acme@jouet linux]$ perf config report.queue-size report.children
> report.children=false
> # report.queue-size=18446744073709551615 # Default, not set in ~/.perfconfig
> [acme@jouet linux]$
>
> ?
>
> - Arnaldo

To also show default config values, first of all,
I think we should have default config arrays.

So I sent v9 PATCH mail for default config arrays!
If you review the patchset, I'd appreciate it! :)


Thanks,
Taeung