Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932345AbcK1JSv (ORCPT <rfc822;w@1wt.eu>);
        Mon, 28 Nov 2016 04:18:51 -0500
Received: from mail-pg0-f43.google.com ([74.125.83.43]:33780 "EHLO
        mail-pg0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S932094AbcK1JSm (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 28 Nov 2016 04:18:42 -0500
Date: Mon, 28 Nov 2016 18:18:31 +0900
From: AKASHI Takahiro <takahiro.akashi@linaro.org>
To: Andreas Ziegler <andreas.ziegler@fau.de>,
        Rusty Russell <rusty@rustcorp.com.au>, Jessica Yu <jeyu@redhat.com>
Cc: Kees Cook <keescook@chromium.org>, kernel-hardening@lists.openwall.com,
        linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] module: extend 'rodata=off' boot cmdline parameter to
 module mappings
Message-ID: <20161128091830.GB23034@linaro.org>
Mail-Followup-To: AKASHI Takahiro <takahiro.akashi@linaro.org>,
        Andreas Ziegler <andreas.ziegler@fau.de>,
        Rusty Russell <rusty@rustcorp.com.au>, Jessica Yu <jeyu@redhat.com>,
        Kees Cook <keescook@chromium.org>,
        kernel-hardening@lists.openwall.com,
        linux-kernel <linux-kernel@vger.kernel.org>
References: <95e7fd98-c477-0c8a-7195-932e04bba9bb@fau.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <95e7fd98-c477-0c8a-7195-932e04bba9bb@fau.de>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 938
Lines: 25

On Mon, Nov 28, 2016 at 08:59:40AM +0100, Andreas Ziegler wrote:
> Hi Akashi,
> 
> your patch "module: extend 'rodata=off' boot cmdline parameter to module
> mappings" showed up in linux-next today, and I noticed a small error in it.
> 
> The first modified #ifdef is fine, the second one, however, has a spelling
> mistake in it: the CONFIG_ variable should be CONFIG_DEBUG_SET_MODULE_RONX
> instead of CONFIG_SET_MODULE_RONX (note the missing DEBUG).

Thank you for pointing this out.
(I didn't notice it because DEBUG_RODATA is always on on arm64.)

Rusty, Jessica, should I submit v4 to correct it?

-Takahiro AKASHI

> I noticed it by running 'scripts/checkkconfigsymbols -f --force -f
> next-20161124..next-20161128', which is essentialy diffing the last two
> linux-next releases and looks for undefined/unknown Kconfig symbols.
> You can also run the script on single commits with -c to test them.
> 
> Best regards,
> 
> Andreas