Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754717AbcK1KgR (ORCPT ); Mon, 28 Nov 2016 05:36:17 -0500 Received: from mga04.intel.com ([192.55.52.120]:36006 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754384AbcK1Kfk (ORCPT ); Mon, 28 Nov 2016 05:35:40 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,563,1473145200"; d="scan'208";a="10402607" Subject: Re: Adding a .platform_init callback to sdhci_arasan_ops To: Michal Simek , Sebastian Frias , Douglas Anderson , =?UTF-8?Q?S=c3=b6ren_Brinkmann?= , Jerry Huang , Ulf Hansson References: <982d633b-e9c4-0f10-052b-e324f094d0f5@xilinx.com> Cc: Linux ARM , LKML , Linus Walleij , Mason , P L Sai Krishna From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Message-ID: <2a949ade-edd7-4690-cd6a-434ae1e663dc@intel.com> Date: Mon, 28 Nov 2016 12:30:37 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <982d633b-e9c4-0f10-052b-e324f094d0f5@xilinx.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1306 Lines: 46 On 28/11/16 09:32, Michal Simek wrote: > +Sai for Xilinx perspective. > > On 25.11.2016 16:24, Sebastian Frias wrote: >> Hi, >> >> When using the Arasan SDHCI HW IP, there is a set of parameters called >> "Hardware initialized registers" >> >> (Table 7, Section "Pin Signals", page 56 of Arasan "SD3.0/SDIO3.0/eMMC4.4 >> AHB Host Controller", revision 6.0 document) >> >> In some platforms those signals are connected to registers that need to >> be programmed at some point for proper driver/HW initialisation. >> >> I found that the 'struct sdhci_ops' contains a '.platform_init' callback >> that is called from within 'sdhci_pltfm_init', and that seems a good >> candidate for a place to program those registers (*). >> >> Do you agree? We already killed .platform_init What is wrong with sdhci_arasan_probe()? >> >> Best regards, >> >> Sebastian >> >> >> (*): This has been prototyped on 4.7 as working properly. >> However, upstream commit: >> >> commit 3ea4666e8d429223fbb39c1dccee7599ef7657d5 >> Author: Douglas Anderson >> Date: Mon Jun 20 10:56:47 2016 -0700 >> >> mmc: sdhci-of-arasan: Properly set corecfg_baseclkfreq on rk3399 >> ... >> >> could affect this solution because of the way the 'sdhci_arasan_of_match' >> struct is used after that commit. >> > >