Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932928AbcK1LJw (ORCPT ); Mon, 28 Nov 2016 06:09:52 -0500 Received: from mail-wj0-f179.google.com ([209.85.210.179]:33996 "EHLO mail-wj0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932874AbcK1LJg (ORCPT ); Mon, 28 Nov 2016 06:09:36 -0500 MIME-Version: 1.0 In-Reply-To: <436c6925-cb0d-afe7-e3a2-384eca15ff42@marvell.com> References: <3cd05a26-d340-476e-bab1-8be9d5446f47@marvell.com> <436c6925-cb0d-afe7-e3a2-384eca15ff42@marvell.com> From: Ulf Hansson Date: Mon, 28 Nov 2016 12:09:33 +0100 Message-ID: Subject: Re: [PATCH 7/10] mmc: sdhci-xenon: Add support to PHYs of Marvell Xenon SDHC To: Ziji Hu Cc: Gregory CLEMENT , Adrian Hunter , "linux-mmc@vger.kernel.org" , Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , Rob Herring , "devicetree@vger.kernel.org" , Thomas Petazzoni , "linux-arm-kernel@lists.infradead.org" , Jimmy Xu , Jisheng Zhang , Nadav Haklai , Ryan Gao , Doug Jones , Victor Gu , "Wei(SOCP) Liu" , Wilson Ding , Romain Perier , Yehuda Yitschak , Marcin Wojtas , Hanna Hawa , Kostya Porotchkin , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 580 Lines: 19 [...] > > Could you please tell me the requirement of "op_code" parameter in > mmc_send_tuning()? > According to mmc_send_tuning(),it seems that tuning command(CMD19/CMD21) > is required. Thus device will not response mmc_send_tuning() if current > speed mode doesn't support tuning command. > Please correct me if I am wrong. > When the mmc core decides it's time to execute tuning, it invokes the ->execute_tuning() host ops, which has the "opcode" as a parameter. You should be able to use it when calling mmc_send_tuning(). [...] Kind regards Uffe