Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754612AbcK1Lo6 (ORCPT ); Mon, 28 Nov 2016 06:44:58 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:34618 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754036AbcK1Lou (ORCPT ); Mon, 28 Nov 2016 06:44:50 -0500 DMARC-Filter: OpenDMARC Filter v1.3.1 smtp.codeaurora.org 7356E60FB1 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=pass smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Barry Day Cc: Stephen Rothwell , Jes Sorensen , Wireless , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: linux-next: build warning after merge of the wireless-drivers-next tree References: <20161128115814.2cabf139@canb.auug.org.au> <87d1hg83rp.fsf@kamboji.qca.qualcomm.com> <20161128081649.GA8403@testbox> Date: Mon, 28 Nov 2016 13:44:40 +0200 In-Reply-To: <20161128081649.GA8403@testbox> (Barry Day's message of "Mon, 28 Nov 2016 18:16:51 +1000") Message-ID: <87oa0zygk7.fsf@kamboji.qca.qualcomm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1515 Lines: 44 Barry Day writes: > On Mon, Nov 28, 2016 at 09:25:30AM +0200, Kalle Valo wrote: >> Stephen Rothwell writes: >> >> > Hi all, >> > >> > After merging the wireless-drivers-next tree, today's linux-next build >> > (x86_64 allmodconfig) produced this warning: >> > >> > In file included from include/linux/usb/ch9.h:35:0, >> > from include/linux/usb.h:5, >> > from drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:32: >> > drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c: In function 'rtl8xxxu_fill_txdesc_v2': >> > include/linux/device.h:1214:36: warning: 'rate' may be used uninitialized in this function [-Wmaybe-uninitialized] >> > #define dev_info(dev, fmt, arg...) _dev_info(dev, fmt, ##arg) >> > ^ >> > drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:4841:6: note: 'rate' was declared here >> > u32 rate; >> > ^ >> > >> > Introduced by commit >> > >> > b4c3d9cfb607 ("rtl8xxxu: Pass tx_info to fill_txdesc in order to have access to retry count") >> > >> > This is a correct diagnosis. >> >> Thanks for the report. Jes, can you send a patch to fix this? (Unless >> someone else beats to it.) >> >> -- >> Kalle Valo > > I posted a patch on the 26th that fixes this Thanks, I see it: https://patchwork.kernel.org/patch/9448225/ The commit log doesn't mention anything about the compilation warning, I'll add that. Also a Fixes line is nice to have. -- Kalle Valo