Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933154AbcK1Oyo (ORCPT ); Mon, 28 Nov 2016 09:54:44 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:57794 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932467AbcK1Oye (ORCPT ); Mon, 28 Nov 2016 09:54:34 -0500 Date: Mon, 28 Nov 2016 09:54:31 -0500 (EST) Message-Id: <20161128.095431.856183735501262965.davem@davemloft.net> To: lsanfil@marvell.com Cc: pavel@ucw.cz, peppe.cavallaro@st.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: stmmac ethernet in kernel 4.4: coalescing related pauses? From: David Miller In-Reply-To: References: <20161123105125.GA26394@amd> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 28 Nov 2016 05:55:09 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 293 Lines: 9 From: Lino Sanfilippo Date: Mon, 28 Nov 2016 14:07:51 +0100 > Calling skb_orphan() in the xmit handler made this issue disappear. This is not the way to handle this problem. The solution is to free the SKBs in a timely manner after the chip has transmitted the frame.