Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933215AbcK1PQX (ORCPT ); Mon, 28 Nov 2016 10:16:23 -0500 Received: from mga09.intel.com ([134.134.136.24]:21058 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932342AbcK1PQO (ORCPT ); Mon, 28 Nov 2016 10:16:14 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,564,1473145200"; d="scan'208";a="10514022" Subject: Re: [PATCH v2] usb: xhci: Remove unuseful 'return' and 'break' statement To: Baolin Wang , Greg KH References: <5788dd3650bed67a1551e209847ecdf732eb745b.1479986112.git.baolin.wang@linaro.org> <20161128072157.GA17504@kroah.com> Cc: mathias.nyman@intel.com, USB , LKML , Mark Brown From: Mathias Nyman Message-ID: <583C49EA.5060504@linux.intel.com> Date: Mon, 28 Nov 2016 17:14:50 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1082 Lines: 31 On 28.11.2016 09:41, Baolin Wang wrote: > On 28 November 2016 at 15:21, Greg KH wrote: >> On Mon, Nov 28, 2016 at 02:29:25PM +0800, Baolin Wang wrote: >>> Hi Mathias, >>> >>> On 24 November 2016 at 19:16, Baolin Wang wrote: >>>> Since these 'return' statements are not generally useful in void >>>> function, remove them. Also remove one unuseful 'break' statement >>>> in xhci_setup_addressable_virt_dev() function. >>>> >>>> Signed-off-by: Baolin Wang >>>> --- >>>> Changes since v1: >>>> - Add description of removing 'break' statement in commitlog. >>>> --- >>> >>> Could you apply this patch if there are no other comments? Thanks. >> >> Less than a week response for a simple cleanup patch? Why the rush and >> pressure? Relax, this really isn't an important patch... > > I am sorry for the pressure, I just thought it is one simple cleanup > patch. It is okay for me to wait for. > Looks ok. If it applies I'll send it forward to usb-next after 4.10-rc1, It should end up in 4.11 -Mathias