Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933297AbcK1Pdi (ORCPT ); Mon, 28 Nov 2016 10:33:38 -0500 Received: from mx0b-0016f401.pphosted.com ([67.231.156.173]:53935 "EHLO mx0b-0016f401.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932357AbcK1Pd3 (ORCPT ); Mon, 28 Nov 2016 10:33:29 -0500 Subject: Re: stmmac ethernet in kernel 4.4: coalescing related pauses? To: David Miller References: <20161123105125.GA26394@amd> <20161128.095431.856183735501262965.davem@davemloft.net> CC: , , , From: Lino Sanfilippo Message-ID: <5a9748bb-26ec-b97a-1e98-582b760024f7@marvell.com> Date: Mon, 28 Nov 2016 16:33:11 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161128.095431.856183735501262965.davem@davemloft.net> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-11-28_04:,, signatures=0 X-Proofpoint-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1609300000 definitions=main-1611280255 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 428 Lines: 16 Hi, On 28.11.2016 15:54, David Miller wrote: > From: Lino Sanfilippo > Date: Mon, 28 Nov 2016 14:07:51 +0100 > >> Calling skb_orphan() in the xmit handler made this issue disappear. > > This is not the way to handle this problem. > I agree, its not a clean solution. But if the use of skb_orphan makes the delays disappear, it can at least be a hint that socket queue limits are involved. Regards, Lino